From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Oleg Bartunov <oleg@sai.msu.su>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: WIP: SP-GiST, Space-Partitioned GiST
Date: Wed, 21 Sep 2011 22:38:22 +0300
Message-ID: <4E7A3D2E.9040901@enterprisedb.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1109030053330.26195@sn.sai.msu.ru>
References: <Pine.LNX.4.64.1108312241050.26195@sn.sai.msu.ru>
<Pine.LNX.4.64.1109011608160.26195@sn.sai.msu.ru>
<Pine.LNX.4.64.1109030053330.26195@sn.sai.msu.ru>
On 05.09.2011 09:39, Oleg Bartunov wrote:
> I attached wrong patch in previous message, sorry ! Here is a last version.
One little detail caught my eye: In spgSplitNodeAction, you call
SpGistGetBuffer() within a critical section. That should be avoided,
SpGistGetBuffer() can easily fail if you e.g run out of disk space.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: heikki.linnakangas@enterprisedb.com, oleg@sai.msu.su
Subject: Re: WIP: SP-GiST, Space-Partitioned GiST
In-Reply-To: <4E7A3D2E.9040901@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox