From: Yeb Havinga <yebhavinga@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Royce Ausburn <royce.ml@inomial.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [REVIEW] Patch for cursor calling with named parameters
Date: Mon, 17 Oct 2011 10:44:38 +0200
Message-ID: <4E9BEAF6.6000001@gmail.com> (raw)
In-Reply-To: <5928.1318657260@sss.pgh.pa.us>
References: <FCEADDEF-8563-4965-8D4A-E37F2328C42B@inomial.com>
<4E8ED2A7.2040800@gmail.com>
<4E8F1315.70109@gmail.com>
<29A8127B-BB37-40DC-8FB6-833710DAB22C@inomial.com>
<4E9438CD.20100@gmail.com>
<5928.1318657260@sss.pgh.pa.us>
On 2011-10-15 07:41, Tom Lane wrote:
> Yeb Havinga<yebhavinga@gmail.com> writes:
>> Hello Royce,
>> Thanks again for testing.
> I looked this patch over but concluded that it's not ready to apply,
> mainly because there are too many weird behaviors around error
> reporting.
Tom, thanks for reviewing - getting the syntax errors to be at the exact
location was indeed something that I thought would be near impossible,
however the whitespace suggestion together with the others you made seem
like a good path to go forward. Thanks for taking the time to write your
comments, it will be a great help with making an improved version.
regards,
Yeb Havinga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: yebhavinga@gmail.com, tgl@sss.pgh.pa.us, royce.ml@inomial.com
Subject: Re: [REVIEW] Patch for cursor calling with named parameters
In-Reply-To: <4E9BEAF6.6000001@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox