pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Florian Pflug <fgp@phlo.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: bug of recovery?
Date: Fri, 02 Dec 2011 10:59:01 +0200
Message-ID: <4ED89355.90006@enterprisedb.com> (raw)
In-Reply-To: <CAHGQGwFLAX09=CJdsNOUe513kwrBGfyop45b8EuHsHBXby1+5Q@mail.gmail.com>
References: <CAHGQGwEEn13awaWZA-fMb76fNXASLLpqmUY8N-sK55ApZy-ErA@mail.gmail.com>
	<CA+U5nML8aK6iMpnaXf=vGYLCRkdqKUFJ6nTLTjEVpLj6oYYTRA@mail.gmail.com>
	<889.1317069556@sss.pgh.pa.us>
	<F4BDC274-D382-4BC2-A093-282E29523DD8@phlo.org>
	<4E816650.80607@enterprisedb.com>
	<DC50F45C-95E9-4F9A-B835-B6BDEEFA4EEC@phlo.org>
	<CAHGQGwHDmzMs-GjYw-k=Ob+YSeK9c9KpDcBzbm1BDNNp5xcb1g@mail.gmail.com>
	<4E896276.7020209@enterprisedb.com>
	<CA+U5nMJewJBQ4xRDsMKNE1KPK2-iwNo9uNWhYrV3SOnYU73ZVw@mail.gmail.com>
	<CAHGQGwFLAX09=CJdsNOUe513kwrBGfyop45b8EuHsHBXby1+5Q@mail.gmail.com>

On 04.10.2011 09:43, Fujii Masao wrote:
> On Mon, Oct 3, 2011 at 4:32 PM, Simon Riggs<simon@2ndquadrant.com>  wrote:
>>> I don't think this should use the rm_safe_restartpoint machinery. As you
>>> said, it's not tied to any specific resource manager. And I've actually been
>>> thinking that we will get rid of rm_safe_restartpoint altogether in the
>>> future. The two things that still use it are the b-tree and gin, and I'd
>>> like to change both of those to not require any post-recovery cleanup step
>>> to finish multi-page operations, similar to what I did with GiST in 9.1.
>>
>> I thought that was quite neat doing it that way, but there's no
>> specific reason to do it that way I guess. If you're happy to rewrite
>> the patch then I guess we're OK.
>>
>> I certainly would like to get rid of rm_safe_restartpoint in the
>> longer term, hopefully sooner.
>
> Though Heikki might be already working on that,...

Just haven't gotten around to it. It's a fair amount of work with little 
user-visible benefit.

> anyway,
> the attached patch is the version which doesn't use rm_safe_restartpoint
> machinery.

Thanks, committed.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com



view thread (24+ messages)

Message-ID: <4ED89355.90006@enterprisedb.com>
Permalink:  ../4ED89355.90006@enterprisedb.com/
Also on:    postgresql.org/message-id/4ED89355.90006@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: heikki.linnakangas@enterprisedb.com, masao.fujii@gmail.com, simon@2ndquadrant.com, fgp@phlo.org, tgl@sss.pgh.pa.us
  Subject: Re: bug of recovery?
  In-Reply-To: <4ED89355.90006@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox