public inbox for [email protected]
help / color / mirror / Atom feedFrom: Chao Li <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Fujii Masao <[email protected]>
Cc: Rafia Sabih <[email protected]>
Cc: vignesh C <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Set notice receiver before libpq connection startup
Date: Thu, 28 May 2026 08:39:48 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<CAHGQGwHnz7FoSx+qQsAHBx_j8Tks+SC-kAPTevrKYfrL08Ee9Q@mail.gmail.com>
<[email protected]>
<CALDaNm3UyoQ91gW2bRP4PXnnfAv3GfmCik614-AtQCiEUAjQYw@mail.gmail.com>
<[email protected]>
<CA+FpmFdfyBhuiou1uqe94UR3WCg57wM5FsooUx2w27aABGoyag@mail.gmail.com>
<CAHGQGwHU2E7h7XBCBNK7OJ+OAx7Xkwn+yUb7o5p5GxExi4fzAw@mail.gmail.com>
<[email protected]>
<CAHGQGwEvA2a+jXZdVrdybX9OmWguSU4Q8wEhZxWKkDMOZHnuMQ@mail.gmail.com>
<[email protected]>
<[email protected]>
> On May 28, 2026, at 01:56, Peter Eisentraut <[email protected]> wrote:
>
> On 23.05.26 01:56, Chao Li wrote:
>>> On May 22, 2026, at 23:28, Fujii Masao <[email protected]> wrote:
>>>
>>> On Fri, May 22, 2026 at 11:56 PM Chao Li <[email protected]> wrote:
>>>> PFA v4, just removed conn NULL check.
>>>
>>> Thanks for updating the patch! I've pushed it.
>>>
>>> Regards,
>>>
>>> --
>>> Fujii Masao
>> Thanks for pushing and still working hard during the PGConf.
>
> The committed patch violates the .gitattributes whitespace rules:
>
> git show --check 06a5c3cdef02
>
> contrib/postgres_fdw/connection.c:651: indent with spaces.
> + /* expand_dbname = */ false);
>
> It is unfortunate that pgindent produces this layout that contradicts the git configuration. (The current formatting also doesn't look like what I would produce in an editor, so I think git is right here.)
>
> Maybe we could reformat this slightly to avoid that? (unless someone wants to try to fix pgindent)
>
>
Ah, I was not aware of the whitespace rule. I think it was not pgindent; I made that change manually. I added “=” because I thought it might read more fluently.
Attached is a fix for that.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
Attachments:
[application/octet-stream] v1-0001-Fix-an-indentation-problem-in-postgres_fdw-connec.patch (1.1K, 2-v1-0001-Fix-an-indentation-problem-in-postgres_fdw-connec.patch)
download | inline diff:
From 1fcadb474e54fe82eb0aa5f8d62ecd2dafede1dc Mon Sep 17 00:00:00 2001
From: "Chao Li (Evan)" <[email protected]>
Date: Thu, 28 May 2026 08:30:22 +0800
Subject: [PATCH v1] Fix an indentation problem in postgres_fdw/connection.c
Reported-by: Peter Eisentraut <[email protected]>
Author: Chao Li <[email protected]>
Reviewed-by:
Discussion: https://postgr.es/m/[email protected]
---
contrib/postgres_fdw/connection.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/postgres_fdw/connection.c b/contrib/postgres_fdw/connection.c
index 346f6f1fbfe..0810b756d38 100644
--- a/contrib/postgres_fdw/connection.c
+++ b/contrib/postgres_fdw/connection.c
@@ -648,7 +648,7 @@ connect_pg_server(ForeignServer *server, UserMapping *user)
/* OK to make connection */
start_conn = libpqsrv_connect_params_start(keywords, values,
- /* expand_dbname = */ false);
+ false /* expand_dbname */ );
PQsetNoticeReceiver(start_conn, libpqsrv_notice_receiver,
"received message via remote connection");
libpqsrv_connect_complete(start_conn, pgfdw_we_connect);
--
2.50.1 (Apple Git-155)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Set notice receiver before libpq connection startup
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox