From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: refactor some protocol message sending in walsender and basebackup
Date: Wed, 6 Jul 2022 08:51:37 +0200
Message-ID: <4b856bab-c37b-559e-1ab6-68f189146013@enterprisedb.com> (raw)
In-Reply-To: <20220701213646.GA582729@nathanxps13>
References: <7e4fdbdc-699c-4cd0-115d-fb78a957fc22@enterprisedb.com>
<20220701213646.GA582729@nathanxps13>
On 01.07.22 23:36, Nathan Bossart wrote:
> On Thu, Jun 23, 2022 at 04:36:36PM +0200, Peter Eisentraut wrote:
>> Some places in walsender.c and basebackup_copy.c open-code the sending of
>> RowDescription and DataRow protocol messages. But there are already more
>> compact and robust solutions available for this, using DestRemoteSimple and
>> associated machinery, already in use in walsender.c.
>>
>> The attached patches 0001 and 0002 are tiny bug fixes I found during this.
>>
>> Patches 0003 and 0004 are the main refactorings. They should probably be
>> combined into one patch eventually, but this way the treatment of
>> RowDescription and DataRow is presented separately.
>
> All 4 patches look reasonable to me.
All committed now, thanks.
(I cleaned up the 0004 patch a bit more; there was some junk left in the
posted patch.)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, nathandbossart@gmail.com
Subject: Re: refactor some protocol message sending in walsender and basebackup
In-Reply-To: <4b856bab-c37b-559e-1ab6-68f189146013@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox