pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Simon Riggs <simon@2ndquadrant.com>
To: Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Pavan Deolasee <pavan.deolasee@2ndquadrant.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] MERGE SQL Statement for PG11
Date: Thu, 5 Apr 2018 07:38:07 -0400
Message-ID: <4cccec00-bf86-1989-bb59-05e57ad3d2a1@redhat.com> (raw)
In-Reply-To: <a1946413-cac0-3d1c-17d6-ccff2aa4fccc@redhat.com>
References: <CAH2-WzkJdBuxj9PO=2QaO9-3h3xGbQPZ34kJH=HukRekwM-GZg@mail.gmail.com>
	<CA+Tgmoam1LtX7KDstYfduQycksPQEu3EeVnayfCB=U7sORGOpg@mail.gmail.com>
	<CA+TgmoZbPMEuEyeL8xOep-MdpYsQNutqhY7j-J3m4k2Xran+uA@mail.gmail.com>
	<CANP8+jKxrNcZX1WBoVLdNKJuQj4g4PyVKLF9ie+Rvae9ONvimw@mail.gmail.com>
	<CABOikdM9hvMCt_nsunLpk1KhQQVwW+-cGH7BfMoh4HqMdbbn-g@mail.gmail.com>
	<CANP8+jKLyN4+qcH7wVR0h-qYCYine3L6x0-a8rD6SajJY-k3XQ@mail.gmail.com>
	<CABOikdOwA4+CJO4MwzF250huNuBWejWugf-GZwrbX-k=NDc2rw@mail.gmail.com>
	<CAH2-WzkNY4o2q_kJGNNqjExcPy=nmFgNn_MvgTXhUOxQw-jyJw@mail.gmail.com>
	<CABOikdMO4G3dBL9HSzP9DBT051uGnd0uejnYAEZk+iYn3AWY2g@mail.gmail.com>
	<CANP8+jLKcQP1Sft5qEZMpHCu7fUD-0vYHRYjcJZAepWjBPz4ng@mail.gmail.com>
	<CANP8+jJj=SHbn3dcOTAhj8gdSgiEwHAMU4Gx=GkRu-zhjhKmig@mail.gmail.com>
	<a1946413-cac0-3d1c-17d6-ccff2aa4fccc@redhat.com>

Hi Simon and Paven,

On 04/04/2018 08:46 AM, Jesper Pedersen wrote:
> On 03/30/2018 07:10 AM, Simon Riggs wrote:
>> No problems found, but moving proposed commit to 2 April pm
>>
> 
> There is a warning for this, as attached.
> 

Updated version due to latest refactoring.

Best regards,
   Jesper

Attachments:


merge_warn_v2.patch (text/x-patch, 416B) download
diff --git a/src/backend/executor/execMerge.c b/src/backend/executor/execMerge.c
index 471f64361d..e35025880d 100644
--- a/src/backend/executor/execMerge.c
+++ b/src/backend/executor/execMerge.c
@@ -48,7 +48,6 @@ ExecMerge(ModifyTableState *mtstate, EState *estate, TupleTableSlot *slot,
 	ItemPointer tupleid;
 	ItemPointerData tuple_ctid;
 	bool		matched = false;
-	char		relkind;
 	Datum		datum;
 	bool		isNull;
 

view thread (265+ messages)  latest in thread

Message-ID: <4cccec00-bf86-1989-bb59-05e57ad3d2a1@redhat.com>
Permalink:  ../4cccec00-bf86-1989-bb59-05e57ad3d2a1@redhat.com/
Also on:    postgresql.org/message-id/4cccec00-bf86-1989-bb59-05e57ad3d2a1@redhat.com

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: jesper.pedersen@redhat.com, simon@2ndquadrant.com, pavan.deolasee@gmail.com, pg@bowt.ie, Langote_Amit_f8@lab.ntt.co.jp, robertmhaas@gmail.com, tomas.vondra@2ndquadrant.com, alvherre@alvh.no-ip.org, andrew.dunstan@2ndquadrant.com, pavan.deolasee@2ndquadrant.com, sfrost@snowman.net
  Subject: Re: [HACKERS] MERGE SQL Statement for PG11
  In-Reply-To: <4cccec00-bf86-1989-bb59-05e57ad3d2a1@redhat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox