From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Ryan Murphy <ryanfmurphy@gmail.com>
To: pgsql-hackers@postgresql.org
Subject: Re: assorted code cleanup
Date: Tue, 5 Sep 2017 15:08:50 -0400
Message-ID: <4cf1f89b-10d2-46b8-bd52-ed48e1ceb462@2ndquadrant.com> (raw)
In-Reply-To: <20170829073246.23546.85121.pgcf@coridan.postgresql.org>
References: <2beab0ef-69f9-dab3-cacd-8fdf417bca96@2ndquadrant.com>
<CA+TgmoZaA_wtvAq0V6G+0yViivakjbMyEDPah9Zgi7H9e6iW4Q@mail.gmail.com>
<20170829073246.23546.85121.pgcf@coridan.postgresql.org>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 8/29/17 03:32, Ryan Murphy wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: tested, passed
>
> I've reviewed the code changes, and it's pretty clear to me that they clean things up a bit while not changing any behavior. They simplify things in a way that make the code more comprehensible. I've run all the tests and they behave the same way as they did before the patch. I also trying manually playing around the the function in question, `metaphone`, and it seems to behave the same as before.
>
> I think it's ready to commit!
>
> The new status of this patch is: Ready for Committer
Pushed, except the one with the function pointers, which some people
didn't like.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, ryanfmurphy@gmail.com
Subject: Re: assorted code cleanup
In-Reply-To: <4cf1f89b-10d2-46b8-bd52-ed48e1ceb462@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox