From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: static assert cleanup
Date: Thu, 15 Dec 2022 10:32:27 +0100
Message-ID: <4d61a288-cc0a-cd79-2cd8-2019415be939@enterprisedb.com> (raw)
In-Reply-To: <CAFBsxsGar4THO2VOj3UMAMq+Ns63eWoa0N94JWvW7FJ-N08TKg@mail.gmail.com>
References: <941a04e7-dd6f-c0e4-8cdf-a33b3338cbda@enterprisedb.com>
<CAFBsxsGar4THO2VOj3UMAMq+Ns63eWoa0N94JWvW7FJ-N08TKg@mail.gmail.com>
On 09.12.22 11:01, John Naylor wrote:
>
> On Fri, Dec 9, 2022 at 2:47 PM Peter Eisentraut
> <peter.eisentraut@enterprisedb.com
> <mailto:peter.eisentraut@enterprisedb.com>> wrote:
> >
> > 0003-Move-some-static-assertions-to-better-places.patch
> >
> > This moves some that I thought were suboptimally placed but it could be
> > debated or refined.
>
> + * We really want ItemPointerData to be exactly 6 bytes. This is rather a
> + * random place to check, but there is no better place.
>
> Since the assert is no longer in a random function body, it seems we can
> remove the second sentence.
Committed with the discussed adjustments.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, john.naylor@enterprisedb.com
Subject: Re: static assert cleanup
In-Reply-To: <4d61a288-cc0a-cd79-2cd8-2019415be939@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox