pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Pierre Giraud <pierre.giraud@dalibo.com>
To: pgsql-hackers@lists.postgresql.org
To: depesz@depesz.com
To: depesz@gmail.com
Subject: Re: [PG13] Planning (time + buffers) data structure in explain plan (format text)
Date: Fri, 21 Aug 2020 07:54:13 +0200
Message-ID: <4e932e5e-8d86-4dcd-632e-f7c6e2c35a83@dalibo.com> (raw)
In-Reply-To: <0d074a53-fd91-b1dd-a529-173d07627465@oss.nttdata.com>
References: <07b226e6-fa49-687f-b110-b7c37572f69e@dalibo.com>
	<20200819032706.GQ17022@telsasoft.com>
	<20200819072133.jnmtux7qbyxywh6r@nol>
	<CAApHDvrDpJNMpXMS3SNkeUitXrZAFRZ3MrzQG6ieC7vQte6aWA@mail.gmail.com>
	<20200819090429.s7hoyyw4a6jumgkc@nol>
	<CAApHDvr0hMeEDB6HE=GE6vc2kJjCoiWe7z+CVyD9CoAUB+Cpjw@mail.gmail.com>
	<e7361ab4-5b6b-9667-e25b-04ae0b070ded@oss.nttdata.com>
	<CAApHDvqWSk5tVqY9=SwsOF03xOJyrvwoavdDoNjV+2Wk10vsuQ@mail.gmail.com>
	<5605ac79-90c0-6a5f-256d-5cabf52a3fe8@oss.nttdata.com>
	<CAApHDvoU32j3FpVFzdf7qrMmhPwd8VTy1g5nAwkh083bWELQxA@mail.gmail.com>
	<CAOBaU_bOrsngOyYhHUZ0tVGzE9FJsB4nviBZQ7zxjehsYmsWPQ@mail.gmail.com>
	<0d074a53-fd91-b1dd-a529-173d07627465@oss.nttdata.com>

Le 20/08/2020 à 17:41, Fujii Masao a écrit :
> 
> 
> On 2020/08/20 22:34, Julien Rouhaud wrote:
>> On Thu, Aug 20, 2020 at 12:29 PM David Rowley <dgrowleyml@gmail.com>
>> wrote:
>>>
>>> On Thu, 20 Aug 2020 at 19:58, Fujii Masao
>>> <masao.fujii@oss.nttdata.com> wrote:
>>>>
>>>> On 2020/08/20 13:00, David Rowley wrote:
>>>>> I forgot to mention earlier, you'll also need to remove the part in
>>>>> the docs that mentions BUFFERS requires ANALYZE.
>>>>
>>>> Thanks for the review! I removed that.
>>>> Attached is the updated version of the patch.
>>>> I also added the regression test performing "explain (buffers on)"
>>>> without "analyze" option.
>>>
>>> Looks good to me.
>>
>> Looks good to me too.
> 
> David and Julien, thanks for the review! I'd like to wait for
> Pierre's opinion about this change before committing the patch.
> 
> Pierre,
> could you share your opinion about this change?

It looks good to me too. Thanks a lot!
Let's not forget to notify Hubert (depesz) once integrated.

> 
> Regards,
> 





view thread (25+ messages)  latest in thread

Message-ID: <4e932e5e-8d86-4dcd-632e-f7c6e2c35a83@dalibo.com>
Permalink:  ../4e932e5e-8d86-4dcd-632e-f7c6e2c35a83@dalibo.com/
Also on:    postgresql.org/message-id/4e932e5e-8d86-4dcd-632e-f7c6e2c35a83@dalibo.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pierre.giraud@dalibo.com, pgsql-hackers@lists.postgresql.org, depesz@depesz.com, depesz@gmail.com
  Subject: Re: [PG13] Planning (time + buffers) data structure in explain plan (format text)
  In-Reply-To: <4e932e5e-8d86-4dcd-632e-f7c6e2c35a83@dalibo.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox