From: Benoit Lobréau <benoit.lobreau@dalibo.com>
To: David Steele <david@pgbackrest.org>
To: Andrey M. Borodin <x4mmm@yandex-team.ru>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Fix logging for invalid recovery timeline
Date: Wed, 19 Feb 2025 10:51:49 +0100
Message-ID: <4ed10bc8-5513-4d8e-8643-8abcaa08336d@dalibo.com> (raw)
In-Reply-To: <d0b27c08-d30f-4a1d-990d-5c90ca0a650a@pgbackrest.org>
References: <c3d617d4-1696-4aa7-8a4d-5a7d19cc5618@pgbackrest.org>
<C748635E-B2FF-4813-B035-AE670832B9FD@yandex-team.ru>
<d0b27c08-d30f-4a1d-990d-5c90ca0a650a@pgbackrest.org>
Hi,
I think the changes make sense. Would it be helpful to add the origin of
the checkpoint record we are referring to ? (i.e. control file or backup
label).
For example:
* Latest checkpoint in the control file is at %X/%X on timeline %u,
* Checkpoint location in the backup_label file is at %X/%X on timeline %u,
The current message refers to "Latest checkpoint" which automatically
makes me think about the control file (specifically, the pg_controldata
output).
Now that I have read the code, I understand which one we are referring
to, but for someone who hasn't (or me in a few month) it might be useful ?
--
Benoit Lobréau
Consultant
http://dalibo.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: benoit.lobreau@dalibo.com, david@pgbackrest.org, x4mmm@yandex-team.ru
Subject: Re: Fix logging for invalid recovery timeline
In-Reply-To: <4ed10bc8-5513-4d8e-8643-8abcaa08336d@dalibo.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox