pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Petr Jelinek <petr@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Rafia Sabih <rafia.pghackers@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: adding partitioned tables to publications
Date: Sat, 4 Apr 2020 10:56:55 +0200
Message-ID: <4f5a1798-9b23-f1fd-4b9e-67d0ea503e4c@2ndquadrant.com> (raw)
In-Reply-To: <13925.1585977907@sss.pgh.pa.us>
References: <CA+HiwqH=Y85vRK3mOdjEkqFK+E=ST=eQiHdpj43L=_eJMOOznQ@mail.gmail.com>
	<b8f257af-3fcd-65b9-088c-0248d82e4e99@2ndquadrant.com>
	<CA+HiwqFZbbJzAZgTjqbRarp_xeqyymuNmGg8Q5tDKTZbk3=c2A@mail.gmail.com>
	<c0d69728-c3d8-ede8-ad31-941b2bbaff66@2ndquadrant.com>
	<CA+HiwqE+6gNgr-BVYeCMT38naRi9cJaanJb7+FCNsX9XgMwHsQ@mail.gmail.com>
	<CA+HiwqFjYE5anArxvkjr37AQMd52L-LZtz9Ld2QrLQ3YfcYhTw@mail.gmail.com>
	<CA+HiwqE+z2=wLv3a41h7JopcnUZAiFPeaiQyxZeGQ62QV3vsPQ@mail.gmail.com>
	<4f999141-97c8-c968-a726-0a1ec3e36e47@2ndquadrant.com>
	<ff6007b3-02c2-8296-2896-db99a51f57e2@2ndquadrant.com>
	<CA+HiwqGWXeBA2xagkz_YdxycmO38Vah_aviyJf_kC_kjCdL-Xg@mail.gmail.com>
	<CA+HiwqGkknVb+ccLVkgw1DoBYPzpuR43L+aT1eOT8dVEtiedtw@mail.gmail.com>
	<44ecae53-98! 61-71b7-1d43-4658acc52519@2ndquadrant.com>
	<5183.1585925998@sss.pgh! .pa.us>
	<e934a27d-bab4-b818-8936-bbcd2d41df0a@2ndquadrant.com>
	<9684.1585929105@sss.pgh.pa.us>
	<63961884-6d56-a12b-d3f5-9a! 5dcbcc37f4@2ndquadrant.com>
	<13925.1585977907@sss.pgh.pa.us>

On 04/04/2020 07:25, Tom Lane wrote:
> Petr Jelinek <petr@2ndquadrant.com> writes:
>> On 03/04/2020 17:51, Tom Lane wrote:
>>> But the forked-off children have to write the gcov files independently,
>>> don't they?
> 
>> Hmm that's very good point. I did see these missing coverage issue when
>> running tests that explicitly start more instances of postgres before
>> though. And with some quick googling, parallel testing seems to be issue
>> with gcov for more people.
> 
> I poked around and found this:
> 
> https://gcc.gnu.org/legacy-ml/gcc-help/2005-11/msg00074.html
> 
> which says
> 
>      gcov instrumentation is multi-process safe, but not multi-thread
>      safe. The multi-processing safety relies on OS level file locking,
>      which is not available on some systems.
> 
> That would explain why it works for me, but then there's a question
> of why it doesn't work for you ...

Hmm, I wonder if it has something to do with docker then (I rarely run 
any tests directly on the main system nowadays). But that does not 
explain why it does not work for Amit either.

-- 
Petr Jelinek
2ndQuadrant - PostgreSQL Solutions for the Enterprise
https://www.2ndQuadrant.com/





view thread (86+ messages)  latest in thread

Message-ID: <4f5a1798-9b23-f1fd-4b9e-67d0ea503e4c@2ndquadrant.com>
Permalink:  ../4f5a1798-9b23-f1fd-4b9e-67d0ea503e4c@2ndquadrant.com/
Also on:    postgresql.org/message-id/4f5a1798-9b23-f1fd-4b9e-67d0ea503e4c@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: petr@2ndquadrant.com, tgl@sss.pgh.pa.us, amitlangote09@gmail.com, peter.eisentraut@2ndquadrant.com, rafia.pghackers@gmail.com
  Subject: Re: adding partitioned tables to publications
  In-Reply-To: <4f5a1798-9b23-f1fd-4b9e-67d0ea503e4c@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox