pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <hlinnakangas@vmware.com>
To: Andres Freund <andres@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: XLByte* usage
Date: Mon, 17 Dec 2012 10:30:18 +0200
Message-ID: <50CED81A.3080400@vmware.com> (raw)
In-Reply-To: <20121216141624.GC4683@awork2.anarazel.de>
References: <20121216141624.GC4683@awork2.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 16.12.2012 16:16, Andres Freund wrote:
> Now that XLRecPtr's are plain 64bit integers what are we supposed to use
> in code comparing and manipulating them? There already is plenty example
> of both, but I would like new code to go into one direction not two...
>
> I personally find direct comparisons/manipulations far easier to read
> than the XLByte* equivalents.

I've still used XLByte* macros, but I agree that plain < = > are easier 
to read. +1 for using < = > in new code.

- Heikki


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (16+ messages)  latest in thread

Message-ID: <50CED81A.3080400@vmware.com>
Permalink:  ../50CED81A.3080400@vmware.com/
Also on:    postgresql.org/message-id/50CED81A.3080400@vmware.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: hlinnakangas@vmware.com, andres@2ndquadrant.com
  Subject: Re: XLByte* usage
  In-Reply-To: <50CED81A.3080400@vmware.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox