From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, Robert Haas <robertmhaas@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Subject: Re: Pointer subtraction with a null pointer
Date: Sat, 26 Mar 2022 12:37:44 -0400
Message-ID: <51678.1648312664@sss.pgh.pa.us> (raw)
In-Reply-To: <20220326163441.qzpcioycozbzarsf@alap3.anarazel.de>
References: <48826.1648310694@sss.pgh.pa.us>
<49360.1648311192@sss.pgh.pa.us>
<20220326163441.qzpcioycozbzarsf@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2022-03-26 12:13:12 -0400, Tom Lane wrote:
>> This code is old, but mylodon wasn't doing that a week ago, so
>> Andres must've updated the compiler and/or changed its options.
> Yep, updated it to clang 13. It's a warning present in 13, but not in 12.
OK, that answers that.
After more thought I agree that replacing these relptr_store calls
with something else would be the better solution. I'll prepare a
patch.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, robertmhaas@gmail.com, thomas.munro@gmail.com
Subject: Re: Pointer subtraction with a null pointer
In-Reply-To: <51678.1648312664@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox