From: Andrew Dunstan <andrew@dunslane.net>
To: cedric@2ndquadrant.com
Cc: pgsql-hackers@postgresql.org, Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Bugfix and new feature for PGXS
Date: Tue, 25 Jun 2013 11:18:51 -0400
Message-ID: <51C9B4DB.8000007@dunslane.net> (raw)
In-Reply-To: <201306250124.54610.cedric@2ndquadrant.com>
References: <201306181552.36673.cedric@2ndquadrant.com>
<201306242202.04162.cedric@2ndquadrant.com>
<51C8C5B2.6080609@dunslane.net>
<201306250124.54610.cedric@2ndquadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 06/24/2013 07:24 PM, Cédric Villemain wrote:
> Le mardi 25 juin 2013 00:18:26, Andrew Dunstan a écrit :
>> On 06/24/2013 04:02 PM, Cédric Villemain wrote:
>>> WIth extension, we do have to set VPATH explicitely if we want to use
>>> VPATH (note that contribs/extensions must not care that postgresql has
>>> been built with or without VPATH set). My patches try to fix that.
>> No, this is exactly what I'm objecting to. I want to be able to do:
>>
>> invoke_vpath_magic
>> standard_make_commands_as_for_non_vpath
>>
>> Your patches have been designed to overcome your particular issues, but
>> they don't meet the general case, IMNSHO. This is why I want to have
>> more discussion about how vpath builds could work for PGXS modules.
> The patch does not restrict anything, it is not supposed to lead to
> regression.
> The assignment of VPATH and srcdir are wrong in the PGXS case, the patch
> correct them. You're still free to do "make VPATH=/mypath ..." the VPATH
> provided won't be erased by the pgxs.mk logic.
I still think this is premature. I have spent some more time trying to
make it work the way I think it should, so far without success. I think
we need more discussion about how we'd like VPATH to work for PGXS
would. There's no urgency about this - we've lived with the current
situation for quite a while.
When I have more time I will work on it some more.
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew@dunslane.net, cedric@2ndquadrant.com, craig@2ndquadrant.com
Subject: Re: Bugfix and new feature for PGXS
In-Reply-To: <51C9B4DB.8000007@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox