From: Andrew Dunstan <andrew@dunslane.net>
To: cedric@2ndquadrant.com
Cc: pgsql-hackers@postgresql.org, Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Bugfix and new feature for PGXS
Date: Sat, 29 Jun 2013 14:42:38 -0400
Message-ID: <51CF2A9E.9030902@dunslane.net> (raw)
In-Reply-To: <201306292027.58057.cedric@2ndquadrant.com>
References: <201306181552.36673.cedric@2ndquadrant.com>
<51CB0011.8020506@dunslane.net>
<51CF1F6D.8020209@dunslane.net>
<201306292027.58057.cedric@2ndquadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 06/29/2013 02:27 PM, Cédric Villemain wrote:
>>
>> I haven't seen a response to this. One thing we are missing is
>> documentation. Given that I'm inclined to commit all of this (i.e.
>> cedric's patches 1,2,3, and 4 plus my addition).
> I did so I sent the mail again. I believe your addition need some changes to
> allow the PGXS+VPATH case as it currently depends on the source-tree tool. So
> it needs to be in postgresql-server-devel packages, thus installed by
> postgresql "make install".
> I'm going to update the doc. It's probably worth to have some examples.
I think we can survive for now without an additional tool. What I did
was a proof of concept, it was not intended as a suggestion that we
should install prep_buildtree. I am only suggesting that, in addition to
your changes, if USE_VPATH is set then that path is used instead of a
path inferred from the name of the Makefile.
A tool to set up a full vpath build tree for extensions or external
modules seems to be beyond the scope of this.
>
>> I'm also inclined to backpatch it, since without that it seems to me
>> unlikely packagers will be able to make practical use of it for several
>> years, and the risk is very low.
> Yes, it is valuable to help packagers here, thanks.
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew@dunslane.net, cedric@2ndquadrant.com, craig@2ndquadrant.com
Subject: Re: Bugfix and new feature for PGXS
In-Reply-To: <51CF2A9E.9030902@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox