pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter_e@gmx.net>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Heikki Linnakangas <hlinnakangas@vmware.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: GIN improvements part 1: additional information
Date: Wed, 25 Sep 2013 09:22:38 -0400
Message-ID: <5242E39E.20604@gmx.net> (raw)
In-Reply-To: <CAPpHfdvbmTrnPg2f6S_E2k2JVmHFipSJPG_ooDHKFbwi4oKfOw@mail.gmail.com>
References: <CAPpHfduxv-iL7aedwPW0W5fXrWGAKfxijWM63_hZujaCRxnmFQ@mail.gmail.com>
	<CAPpHfduQrtC4B+MC9_z3QB8oJsK1Ws-H8ivEsy_cmDnfoJqkeQ@mail.gmail.com>
	<CAPpHfdszEJhSynTPX6=tB3aKq1EA1JXpwx4xiFYM097K7PhQLA@mail.gmail.com>
	<CAPpHfdu8=5spaS7c9mxwH7bNMDR6n378fZCv6c2Y3YM7iE5KiQ@mail.gmail.com>
	<51CEA13C.8040103@vmware.com>
	<CAPpHfdutJEC9+6vWX579afZKzdHKCT2wzDkAEom1XmiXEwF3pw@mail.gmail.com>
	<5236B6A2.8080607@vmware.com>
	<CAPpHfduiTGZ+xGUPYXjckYVe2cuqx7SVaTsvjVJq5j0ywx6-NQ@mail.gmail.com>
	<CAPpHfdvHZXDGNoGvi9qFQcXQnx_e3u9Rkumtx8gTwpx_EhF6JA@mail.gmail.com>
	<CAPpHfdvbmTrnPg2f6S_E2k2JVmHFipSJPG_ooDHKFbwi4oKfOw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 9/23/13 5:36 PM, Alexander Korotkov wrote:
> In the attached version of patch double finding of ItemPointer during
> insert is avoided. Overhead becomes lower as expected.

Fails cpluspluscheck:

./src/include/access/gin_private.h: In function ‘char*
ginDataPageLeafReadItemPointer(char*, ItemPointer)’:
./src/include/access/gin_private.h:797:2: warning: comparison between
signed and unsigned integer expressions [-Wsign-compare]



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (119+ messages)  latest in thread

Message-ID: <5242E39E.20604@gmx.net>
Permalink:  ../5242E39E.20604@gmx.net/
Also on:    postgresql.org/message-id/5242E39E.20604@gmx.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter_e@gmx.net, aekorotkov@gmail.com, hlinnakangas@vmware.com
  Subject: Re: GIN improvements part 1: additional information
  In-Reply-To: <5242E39E.20604@gmx.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox