pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Heikki Linnakangas <hlinnakangas@vmware.com>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Tomas Vondra <tv@fuzzy.cz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: GIN improvements part 1: additional information
Date: Fri, 24 Jan 2014 10:50:48 +0200
Message-ID: <52E22968.2050100@vmware.com> (raw)
In-Reply-To: <CAPpHfduaLDYjXRw8q5+Fnjbe_3SgvKZbNHXJ952VbFLi5H6HDQ@mail.gmail.com>
References: <CAPpHfdutJEC9+6vWX579afZKzdHKCT2wzDkAEom1XmiXEwF3pw@mail.gmail.com>
	<52B49C34.8060300@vmware.com>
	<CA+HiwqGO91OEE0ZBa0q2RqFEKm5dy5VzXrf7uoYObw9BCKSEVA@mail.gmail.com>
	<CAPpHfduBDxQ7Tw5bZCCgxmJzNHDRG6eELAuseuCEvKt=dw0Yfw@mail.gmail.com>
	<52D0A947.6050706@fuzzy.cz>
	<CAPpHfdskbPbjWYJhkd-FkZCKEUZd03PRAw05NyT0Hd-jxWOyfg@mail.gmail.com>
	<52D478F2.6070005@fuzzy.cz>
	<52D5E1BC.3000208@fuzzy.cz>
	<CAPpHfdv9Pheu5atEEUk75f_S1nf6vCoRqge2yUQ1v3xgZ4UP3g@mail.gmail.com>
	<CAPpHfds0A03zwmYdhKUg6s01Vq1p30n01=3c-tct264QTpV--Q@mail.gmail.com>
	<52D9789E.3030202@vmware.com>
	<52DDD51E.2080408@fuzzy.cz>
	<52DE3F55.80103@vmware.com>
	<52DEE4BF.6010203@vmware.com>
	<CAPpHfdtk+1s3EYE5LZFQr8Xb2Ms_apt67Dj0jb3uAyZj9m34XA@mail.gmail.com>
	<52DF819E.4070507@vmware.com>
	<CAPpHfdu2QBSFvBs=NqssSt-FeXgxhFzDivkso-fwC3VfiV_5eA@mail.gmail.com>
	<52DFFFD0.6020708@vmware.com>
	<CAPpHfdtgqY8AXnCQ7E2v6Y7FLtUTK1YE9wPNSvTCNOyQ8j0eAg@mail.gmail.com>
	<CAPpHfduaLDYjXRw8q5+Fnjbe_3SgvKZbNHXJ952VbFLi5H6HDQ@mail.gmail.com >
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 01/24/2014 10:03 AM, Alexander Korotkov wrote:
> ITSM I found this bug. ginVacuumPostingTreeLeaf re-encodes only some
> segments. Others are not even re-palloced. They are moved left
> in dataPlaceToPageLeafRecompress by memcpy. But it's incorrect to with
> memcpy, proper solution is memmove. Using memcpy platform dependently can
> lead to page corruption. Another solution is to re-palloc segments in
> ginVacuumPostingTreeLeaf.

Good catch. Thanks, committed, changing memcpy to memmove. Will have to 
switch to pallocing everything in the future, if we make leafRepackItems 
smarter, so that it doesn't rewrite all the segments after the first 
modified one.

- Heikki


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (119+ messages)  latest in thread

Message-ID: <52E22968.2050100@vmware.com>
Permalink:  ../52E22968.2050100@vmware.com/
Also on:    postgresql.org/message-id/52E22968.2050100@vmware.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: hlinnakangas@vmware.com, aekorotkov@gmail.com, tv@fuzzy.cz
  Subject: Re: GIN improvements part 1: additional information
  In-Reply-To: <52E22968.2050100@vmware.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox