pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Drouvot, Bertrand <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jacob Champion <jchampion@timescale.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Patch proposal: make use of regular expressions for the username in pg_hba.conf
Date: Wed, 19 Oct 2022 09:50:45 +0200
Message-ID: <531b1394-bdb3-8b81-715c-c5bb49d0369f@gmail.com> (raw)
In-Reply-To: <Y09Qcpz776toTxh3@paquier.xyz>
References: <YylB+vmF9dti1Alq@paquier.xyz>
	<e3091081-dc98-7f2b-829f-c247b9337653@gmail.com>
	<Yz0xO0emJ+mxtj2a@paquier.xyz>
	<e346f82f-4a6b-22f7-d6c1-cef16d472de9@gmail.com>
	<Y0UNP4FJyOBn6WX5@paquier.xyz>
	<607af3c9-e45d-3941-41a2-d21065d6594b@gmail.com>
	<Y0jz8QeyeEsnXKlm@paquier.xyz>
	<b5e61748-a38e-60a0-a208-e813269661dc@gmail.com>
	<Y04+/KMwnQszTSK7@paquier.xyz>
	<5000f886-e640-b284-fa64-5cef28b6d272@gmail.com>
	<Y09Qcpz776toTxh3@paquier.xyz>

Hi,

On 10/19/22 3:18 AM, Michael Paquier wrote:
> On Tue, Oct 18, 2022 at 09:14:21AM +0200, Drouvot, Bertrand wrote:
>> BTW, what about adding a new TAP test (dedicated patch) to test the behavior
>> in case of errors during the regexes compilation in pg_ident.conf and
>> pg_hba.conf (not done yet)? (we could add it once this  patch series is
>> done).
> 
> Perhaps, that may become tricky when it comes to -DEXEC_BACKEND (for
> cases where no fork() implementation is available, aka Windows).  But
> a postmaster restart failure would generate logs that could be picked
> for a pattern check?

Right, that's how I'd see it. I'll give it a look.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com





view thread (37+ messages)  latest in thread

Message-ID: <531b1394-bdb3-8b81-715c-c5bb49d0369f@gmail.com>
Permalink:  ../531b1394-bdb3-8b81-715c-c5bb49d0369f@gmail.com/
Also on:    postgresql.org/message-id/531b1394-bdb3-8b81-715c-c5bb49d0369f@gmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: bertranddrouvot.pg@gmail.com, michael@paquier.xyz, tgl@sss.pgh.pa.us, jchampion@timescale.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Patch proposal: make use of regular expressions for the username in pg_hba.conf
  In-Reply-To: <531b1394-bdb3-8b81-715c-c5bb49d0369f@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox