pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Petr Jelinek <petr@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
To: Andres Freund <andres@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Antonin Houska <antonin.houska@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: bgworker crashed or not?
Date: Wed, 16 Apr 2014 22:47:29 +0200
Message-ID: <534EEC61.7000006@2ndquadrant.com> (raw)
In-Reply-To: <CA+TgmoZLwmkZ2O6T29qAb9EhO-9cyz4Rj9mjLQVkFe673CooWA@mail.gmail.com>
References: <20140416131052.GG17874@awork2.anarazel.de>
	<CA+TgmoYy2oJL7t-rknyVENm=vnqTTtb=R-TDkMsrMrgbhQDiew@mail.gmail.com>
	<20140416152803.GJ17874@awork2.anarazel.de>
	<CA+TgmoZPrzktkbwYRgv2fbhBi2_ty9BEtV6Gk-SSrERROZUkvw@mail.gmail.com>
	<20140416154412.GL17874@awork2.anarazel.de>
	<27214.1397663665@sss.pgh.pa.us>
	<20140416160047.GM17874@awork2.anarazel.de>
	<CA+TgmoZe4zqRAX8rgpy9UWy=PE7=3B_1J34bTehEi25hCgr3kw@mail.gmail.com>
	<20140416161143.GN17874@awork2.anarazel.de>
	<CA+TgmoaefVEJeO7+D=VE35Aj2fkgZ3YVqWx8Svzd3v493iJSvg@mail.gmail.com>
	<20140416162837.GO17874@awork2.anarazel.de>
	<CA+TgmoZLwmkZ2O6T29qAb9EhO-9cyz4Rj9mjLQVkFe673CooWA@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 16/04/14 18:34, Robert Haas wrote:
> On Wed, Apr 16, 2014 at 12:28 PM, Andres Freund <andres@2ndquadrant.com> wrote:
>> On 2014-04-16 12:20:01 -0400, Robert Haas wrote:
>>> On Wed, Apr 16, 2014 at 12:11 PM, Andres Freund <andres@2ndquadrant.com> wrote:
>>> I'm still not seeing the problem.  It's the background worker's job to
>>> make sure that the right stuff gets logged, just as it would be for
>>> any other backend.  Trying to bolt some portion of the responsibility
>>> for that onto the postmaster is 100% wrong.
>>
>> Well, it already has taken on that responsibility, it's not my idea to
>> add it. I merely want to control more precisely what happens.s
>
> I think that's doubling down on an already-questionable design principle.
>
> Or if I may be permitted a more colloquial idiom:
>
> Luke, it's a trap.
>

Well the logging is just too spammy in general when it comes to dynamic 
bgworkers but that's easy to fix in the future, no need to make 
decisions for 9.4.

However I really don't like that I have to exit with exit code 1, which 
is normally used as failure, if I want to shutdown my dynamic bgworker 
once it has finished the work. And this behavior is something we can set 
properly only once...


-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (36+ messages)  latest in thread

Message-ID: <534EEC61.7000006@2ndquadrant.com>
Permalink:  ../534EEC61.7000006@2ndquadrant.com/
Also on:    postgresql.org/message-id/534EEC61.7000006@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: petr@2ndquadrant.com, robertmhaas@gmail.com, andres@2ndquadrant.com, tgl@sss.pgh.pa.us, antonin.houska@gmail.com
  Subject: Re: bgworker crashed or not?
  In-Reply-To: <534EEC61.7000006@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox