From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Subject: Re: Large writable variables
Date: Wed, 17 Oct 2018 15:40:16 -0400
Message-ID: <5375.1539805216@sss.pgh.pa.us> (raw)
In-Reply-To: <32621.1539803353@sss.pgh.pa.us>
References: <20181015200754.7y7zfuzsoux2c4ya@alap3.anarazel.de>
<CA+Tgmobk-6=b2KLRRMUWGNWi9KzKrx=WNszr7DDE+QCuwNyrEQ@mail.gmail.com>
<20181016193303.hqpduztwt6ufmasm@alap3.anarazel.de>
<13249.1539733722@sss.pgh.pa.us>
<20181017183406.ddt3n5dkqbl45l56@alap3.anarazel.de>
<32621.1539803353@sss.pgh.pa.us>
I wrote:
> Andres Freund <andres@anarazel.de> writes:
>> .data 0000000000001180 datetktbl ./src/interfaces/ecpg/pgtypeslib/dt_common.o
>> .data 0000000000000c28 ibmkanji ./src/backend/utils/mb/conversion_procs/euc_jp_and_sjis/euc_jp_and_sjis.o
>> .data 00000000000003f0 deltatktbl ./src/interfaces/ecpg/pgtypeslib/dt_common.o
> Hmm. I think these can just be marked const, will investigate.
I pushed fixes for these, but curiously, the ibmkanji change did not
make any difference to section sizes --- AFAICT, my toolchain already
figured out that it could treat that table as const. The dt_common.c
changes are a win though.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, robertmhaas@gmail.com, thomas.munro@enterprisedb.com
Subject: Re: Large writable variables
In-Reply-To: <5375.1539805216@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox