From: Heikki Linnakangas <hlinnakangas@vmware.com>
To: Andres Freund <andres@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgreSQL.org>
Subject: Re: Logical replication woes
Date: Fri, 16 May 2014 11:35:48 +0300
Message-ID: <5375CDE4.5050200@vmware.com> (raw)
In-Reply-To: <20140515205820.GE16014@awork2.anarazel.de>
References: <5374F1FF.9000902@vmware.com>
<5374F44B.1060003@vmware.com>
<20140515174657.GI23662@alap3.anarazel.de>
<537515ED.5060106@vmware.com>
<20140515205820.GE16014@awork2.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 05/15/2014 11:58 PM, Andres Freund wrote:
> On 2014-05-15 22:30:53 +0300, Heikki Linnakangas wrote:
>>> Attached patch fixes things, but I want to add some regression tests
>>> before commit.
>>
>> Looks good to me.
>
> Attached are two patches. One for the unitialized dbId/tsId issue; one
> for the decoding bug. The former should be backpatched.
Thanks, committed.
> Should you wonder about the slight reordering of the assignments in
> RecordTransactionCommitPrepared() - I've made it more similar to RecordTransactionCommit()
> to make it easier to see they are equivalent.
Makes sense.
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: hlinnakangas@vmware.com, andres@2ndquadrant.com
Subject: Re: Logical replication woes
In-Reply-To: <5375CDE4.5050200@vmware.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox