pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Heikki Linnakangas <hlinnakangas@vmware.com>
To: Stephen Frost <sfrost@snowman.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: PQgetssl() and alternative SSL implementations
Date: Wed, 28 Jan 2015 19:18:53 +0200
Message-ID: <54C919FD.1000809@vmware.com> (raw)
In-Reply-To: <20150128165847.GY3854@tamriel.snowman.net>
References: <53F1E989.8020609@vmware.com>
	<CA+TgmoZDJ6CKiuBMqNk3iS7LQ9GZuzS7RTYSOvRu8kJjRKWLng@mail.gmail.com>
	<CABUevExpTZpMAMvr=BkeO5-XG_zgZP=TKdyCCpgEpYc0Htjr8Q@mail.gmail.com>
	<10419.1408475397@sss.pgh.pa.us>
	<CABUevEy03OvP3N3wBRVP7BcmwcHf=Qi6Crb2MHo4dVmG--ZnVg@mail.gmail.com>
	<CA+TgmoaKHd+HW8kOgzovdSTWhauEsV0qeRsxPLpEZfSNDiSP=g@mail.gmail.com>
	<53F3C87E.2080401@vmware.com>
	<54C8FCB0.4050304@vmware.com>
	<CA+TgmoYrAH=o8m9959O_TgHm7OcK9C=f3WJfUHryb4pzu5uZ0A@mail.gmail.com>
	<20150128165847.GY3854@tamriel.snowman.net>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 01/28/2015 06:58 PM, Stephen Frost wrote:
>> >Although I think "OpenSSL SSL" is a little bit duplicatively
>> >redundant.  Why not just "OpenSSL"?
> I wondered also, but figured it was probably because it's OpenSSL's
> "ssl" structure, which then made sense.

Right, that was the idea. I wanted it to include the word "OpenSSL", to 
make it clear in the callers that it's specific to OpenSSL. And SSL, 
because that's the name of the struct. I agree it looks silly, though. 
One idea is to have two separate arguments: the implementation name, and 
the struct name. PQgetSSLstruct(&ssl, "OpenSSL", "SSL") would look less 
silly.

- Heikki



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (44+ messages)  latest in thread

Message-ID: <54C919FD.1000809@vmware.com>
Permalink:  ../54C919FD.1000809@vmware.com/
Also on:    postgresql.org/message-id/54C919FD.1000809@vmware.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: hlinnakangas@vmware.com, sfrost@snowman.net, robertmhaas@gmail.com, magnus@hagander.net, tgl@sss.pgh.pa.us
  Subject: Re: PQgetssl() and alternative SSL implementations
  In-Reply-To: <54C919FD.1000809@vmware.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox