pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Steele <david@pgmasters.net>
To: Sawada Masahiko <sawada.mshk@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Tatsuo Ishii <ishii@postgresql.org>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Abhijit Menon-Sen <ams@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Subject: Re: Auditing extension for PostgreSQL (Take 2)
Date: Fri, 01 May 2015 08:24:14 -0400
Message-ID: <5543706E.8020207@pgmasters.net> (raw)
In-Reply-To: <CAD21AoCRhxrXuFOGLMHNuyfzTCqwHPSKrZWwsw+M8cv_CawFag@mail.gmail.com>
References: <552326EE.4060509@pgmasters.net>
	<CA+U5nMJkT0ZR3ZD-NhqX=OAfpMJak2ORUE4q=3+zFHay6yuTNw@mail.gmail.com>
	<552D2C1A.3060002@pgmasters.net>
	<20150415.081354.1167351714960358354.t-ishii@sraoss.co.jp>
	<552DA959.2010102@pgmasters.net>
	<CAD21AoDUG8G90SUo70JL=AKDA4dXGNb_wAc4-MvxtwvuMRO0kA@mail.gmail.com>
	<CAD21AoCdr6R7T-PuAQf7S70c6qqX1JvBV55idbfcPtz_tEZ5hQ@mail.gmail.com>
	<552EA121.1090603@pgmasters.net>
	<CAD21AoBoS6Q5yjB05LpfKTzhKmarqwwVq06fuPDFsm0T8gSk_Q@mail.gmail.com>
	<5534FC6E.9030906@pgmasters.net>
	<CAD21AoCxFOLWk-k179PyFxzwjkOW8oPaNk73GxZi+Yw2+n4YFA@mail.gmail.com>
	<553938A1.7030707@pgmasters.net>
	<CAD21AoDBt44ABM_0WMketM8bZtqLBMrJpd9RD5tE=Dkr57ft_A@mail.gmail.com>
	<553FA477.5010803@pgmasters.net>
	<CAD21AoCQSGZ5x+sfs4g1x_8Fip60x8ULQFTAGB5XTrKQZvPWPA@mail.gmail.com>
	<CAHGQGwGJnRW69rSL1=tza571_eA44hBeChg-NAVrqQytESgvLg@mail.gmail.com>
	<55429DA5.40503@pgmasters.net>
	<CAD21AoCRhxrXuFOGLMHNuyfzTCqwHPSKrZWwsw+M8cv_CawFag@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 5/1/15 5:58 AM, Sawada Masahiko wrote:
> On Fri, May 1, 2015 at 6:24 AM, David Steele <david@pgmasters.net> wrote:
>>
>> May 15th is the feature freeze, so that does give a little time.  It's
>> not clear to me what a "self-contained" part of the patch would be.  If
>> you have specific ideas on what could be broken out I'm interested to
>> hear them.
>>
>> Patch v11 is attached with the changes discussed here plus some other
>> improvements to the documentation suggested by Erik.
>>
> 
> For now, since pg_audit patch has a pg_audit_ddl_command_end()
> function which uses part of un-committed "deparsing utility commands"
> patch API,
> pg_audit patch is completely depend on that patch.
> If API name, interface are changed, it would affect for pg_audit patch.
> I'm not sure about progress of "deparsing utility command" patch but
> you have any idea if that patch is not committed into 9.5 until May
> 15?

Currently the deparse dependent code is ifdef'd so pg_audit compiles and
operates just fine against master.  Having the deparse code is nice
because it allows less common object types to log with full-qualified
names but it is in not a requirement for pg_audit.

I'd like to see at least patch 0001 of deparse committed.  Not only
because it provides the functionality that deparse uses, but because it
makes event triggers truly useful in pl/pgsql.

-- 
- David Steele
david@pgmasters.net

Attachments:

  signature.asc (application/pgp-signature, 818B) download

view thread (65+ messages)  latest in thread

Message-ID: <5543706E.8020207@pgmasters.net>
Permalink:  ../5543706E.8020207@pgmasters.net/
Also on:    postgresql.org/message-id/5543706E.8020207@pgmasters.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: david@pgmasters.net, sawada.mshk@gmail.com, masao.fujii@gmail.com, simon@2ndquadrant.com, ishii@postgresql.org, ams@2ndquadrant.com, alvherre@2ndquadrant.com
  Subject: Re: Auditing extension for PostgreSQL (Take 2)
  In-Reply-To: <5543706E.8020207@pgmasters.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox