pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Steele <david@pgbackrest.org>
To: shihao zhong <zhong950419@gmail.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Andy Pogrebnoi <andrew.pogrebnoi@percona.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Haibo Yan <tristan.yim@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: Shaun Thomas <shaun.thomas@pgedge.com>
Subject: Re: Return pg_control from pg_backup_stop().
Date: Mon, 28 Sep 2026 06:03:21 +0000 (UTC)
Message-ID: <556bef11-938d-45ca-94b3-7143a3cb532d@pgbackrest.org> (raw)
In-Reply-To: <CAGRkXqRziLU_gQNM6J39n_ce0OE1EBg1=DvwXyZoRK-fYxhqSg@mail.gmail.com>
References: <8b8aa673-fcef-4e14-a05d-0885283ef1b8@pgbackrest.org>
	<aboDQSoywyKGGNCr@paquier.xyz>
	<1800c83c-264a-4183-9da5-ac78e25849a8@pgbackrest.org>
	<abov3-Kre8ntiL-S@paquier.xyz>
	<3b23e3b7-53d2-4784-b482-05cca3327acb@pgbackrest.org>
	<abphw4g2TwuPP0Cv@paquier.xyz>
	<df9e4c1f-4178-47fb-abdd-9829f7079b44@pgbackrest.org>
	<CA+aWR10d__mdN1pVbrCmmsSHG=0mur=fw9PBcL7k9bdoJ1qmKQ@mail.gmail.com>
	<CAPEjYe=QxL7Hn5CCcMpOm9use+s-ZhB2=NAOJPvDvy6DJaum=A@mail.gmail.com>
	<CAGRkXqSZUyXRq+Y9dOwfY52q1_KeR3_t2=o0x3djPTaS-jtY3A@mail.gmail.com>
	<c0d71fe5-c394-4387-8f13-9db44ea01988@pgbackrest.org>
	<A5E4F60C-C7C9-4FDE-8CD9-BC1E19A05674@yandex-team.ru>
	<d9372aa0-0990-445a-b928-0902cd7088a9@pgbackrest.org>
	<CAGRkXqQ737wzDadAh3qQncZm-S8QBEPu5NdiK2u_c8DDHsj=9g@mail.gmail.com>
	<4771ba04-ca9d-4bd0-be09-14bbb9243e33@pgbackrest.org>
	<CAGRkXqTJPM_4QAjzVe1yOiW2HGVC3epmBBVhqqnKswZ_h+YMYQ@mail.gmail.com>
	<CAGRkXqRziLU_gQNM6J39n_ce0OE1EBg1=DvwXyZoRK-fYxhqSg@mail.gmail.com>

Hi Shihao,

On 9/27/26 19:13, shihao zhong wrote:
> 
> On the pg_resetwal patch, one question before I write it. A restored backup
> is never cleanly shut down, so pg_resetwal already needs -f there. A
> backup_label check that -f overrides would only change the message. I'd
> rather refuse even with -f, like the postmaster.pid check, and make the user
> remove backup_label by hand. 058 would then need to remove backup_label
> before its pg_resetwal step.
I would definitely prefer to force the user to remove backup_label 
before pg_resetwal will continue (even with -f). The presence of 
backup_label indicates they are making a mistake by using pg_resetwal, 
when they should probably be configuring recovery instead.

Regards,
-David






view thread (64+ messages)  latest in thread

Message-ID: <556bef11-938d-45ca-94b3-7143a3cb532d@pgbackrest.org>
Permalink:  ../556bef11-938d-45ca-94b3-7143a3cb532d@pgbackrest.org/
Also on:    postgresql.org/message-id/556bef11-938d-45ca-94b3-7143a3cb532d@pgbackrest.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: david@pgbackrest.org, zhong950419@gmail.com, x4mmm@yandex-team.ru, andrew.pogrebnoi@percona.com, michael@paquier.xyz, tristan.yim@gmail.com, hlinnaka@iki.fi, robertmhaas@gmail.com, andres@anarazel.de, masao.fujii@gmail.com, shaun.thomas@pgedge.com
  Subject: Re: Return pg_control from pg_backup_stop().
  In-Reply-To: <556bef11-938d-45ca-94b3-7143a3cb532d@pgbackrest.org>
  References: <8b8aa673-fcef-4e14-a05d-0885283ef1b8@pgbackrest.org> <1800c83c-264a-4183-9da5-ac78e25849a8@pgbackrest.org> <abov3-Kre8ntiL-S@paquier.xyz> <3b23e3b7-53d2-4784-b482-05cca3327acb@pgbackrest.org> <abphw4g2TwuPP0Cv@paquier.xyz> <df9e4c1f-4178-47fb-abdd-9829f7079b44@pgbackrest.org> <CA+aWR10d__mdN1pVbrCmmsSHG=0mur=fw9PBcL7k9bdoJ1qmKQ@mail.gmail.com> <CAPEjYe=QxL7Hn5CCcMpOm9use+s-ZhB2=NAOJPvDvy6DJaum=A@mail.gmail.com> <CAGRkXqSZUyXRq+Y9dOwfY52q1_KeR3_t2=o0x3djPTaS-jtY3A@mail.gmail.com> <c0d71fe5-c394-4387-8f13-9db44ea01988@pgbackrest.org> <A5E4F60C-C7C9-4FDE-8CD9-BC1E19A05674@yandex-team.ru> <d9372aa0-0990-445a-b928-0902cd7088a9@pgbackrest.org> <CAGRkXqQ737wzDadAh3qQncZm-S8QBEPu5NdiK2u_c8DDHsj=9g@mail.gmail.com> <4771ba04-ca9d-4bd0-be09-14bbb9243e33@pgbackrest.org> <CAGRkXqTJPM_4QAjzVe1yOiW2HGVC3epmBBVhqqnKswZ_h+YMYQ@mail.gmail.com> <CAGRkXqRziLU_gQNM6J39n_ce0OE1EBg1=DvwXyZoRK-fYxhqSg@mail.gmail.com> <556bef11-938d-45ca-94b3-7143a3cb532d@pgbackrest.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox