From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Jacob Champion <pchampion@vmware.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: info@cspug.cz
Subject: Re: Preventing abort() and exit() calls in libpq
Date: Wed, 30 Jun 2021 10:09:32 -0400
Message-ID: <566226.1625062172@sss.pgh.pa.us> (raw)
In-Reply-To: <202106301258.xdrqcxocchyg@alvherre.pgsql>
References: <202106301258.xdrqcxocchyg@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Maybe there's something about the linker flags being used.
> ... ah yeah, if I configure with coverage enabled on my machine, it fails in the same way.
Ah-hah, yeah, I see it too if I enable profiling. I can confirm
that it's not from the abort() call in path.c, because it's still
there if I remove that. So this is another case where build
infrastructure is injecting abort() calls we didn't ask for.
Between this and the icc case, I'm now inclined to give up on
trying to forbid abort() calls in libpq. I think the value-add
for that is a lot lower than it is for exit() anyway. abort()
is something one doesn't toss around lightly.
You mentioned __gcov_exit, but I'm not sure if we need an
exception for that. I see it referenced by the individual .o
files, but the completed .so has no such reference, so at least
on RHEL8 it's apparently satisfied during .so linkage. Do you
see something different?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, michael@paquier.xyz, pchampion@vmware.com, daniel@yesql.se, info@cspug.cz
Subject: Re: Preventing abort() and exit() calls in libpq
In-Reply-To: <566226.1625062172@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox