From: Drouvot, Bertrand <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag
Date: Mon, 2 Oct 2023 10:53:22 +0200
Message-ID: <566c1686-c80b-4d4a-b496-b00ac428a095@gmail.com> (raw)
In-Reply-To: <ZRp8t67SqcF2oYqM@paquier.xyz>
References: <bcc36259-7850-4882-97ef-d6b905d2fc51@gmail.com>
<ZRZsg2pqrCQ9dlsn@paquier.xyz>
<eea89922-70e2-4a50-b990-4c6a9757a840@gmail.com>
<ZRp8t67SqcF2oYqM@paquier.xyz>
Hi,
On 10/2/23 10:17 AM, Michael Paquier wrote:
> On Mon, Oct 02, 2023 at 10:01:04AM +0200, Drouvot, Bertrand wrote:
>> I think that would make sense to have more flexibility in the worker_spi
>> module. I think that could be done in a dedicated patch though. I
>> think it makes more sense to have the current patch "focusing" on
>> this new flag (while adding a test about it without too much
>> refactoring). What about doing the worker_spi module re-factoring
>> as a follow up of this one?
>
> I would do that first, as that's what I usually do,
The reason I was thinking not doing that first is that there is no real use
case in the current worker_spi module test.
> but I see also
> your point that this is not mandatory. If you want, I could give it a
> shot tomorrow to see where it leads.
Oh yeah that would be great (and maybe you already see a use case in the
current test). Thanks!
>> Oh right, worth to modify 019_replslot_limit.pl, 002_corrupted.pl and
>> 001_pg_controldata.pl in a separate patch for consistency? (they are using
>> "(stat $node->logfile)[7]" or "(stat($pg_control))[7]").
>
> Indeed, that's strange. Let's remove the dependency to stat here.
> The other solution is slightly more elegant IMO, as we don't rely on
> the position of the result from stat().
Agree, I will propose a new patch for this.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: bertranddrouvot.pg@gmail.com, michael@paquier.xyz
Subject: Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag
In-Reply-To: <566c1686-c80b-4d4a-b496-b00ac428a095@gmail.com>
References: <bcc36259-7850-4882-97ef-d6b905d2fc51@gmail.com> <ZRZsg2pqrCQ9dlsn@paquier.xyz> <eea89922-70e2-4a50-b990-4c6a9757a840@gmail.com> <ZRp8t67SqcF2oYqM@paquier.xyz> <566c1686-c80b-4d4a-b496-b00ac428a095@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox