pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
To: pgsql-hackers@postgresql.org
Subject: Re: WIP: Covering + unique indexes.
Date: Tue, 19 Jan 2016 20:15:46 +0300
Message-ID: <569E6F42.9040601@postgrespro.ru> (raw)
In-Reply-To: <CAMkU=1yTjAK3yCdSoVF1uf3gdvvi3qGnt691g9G0BVhwANCixw@mail.gmail.com>
References: <56167F09.3090101@postgrespro.ru>
	<56168952.4010101@postgrespro.ru>
	<CAA-aLv7mWdu5WCrUH0sw79abDsq4tdZEpkvV8SfgNyLp92+z6Q@mail.gmail.com>
	<5617DAA3.6080408@postgrespro.ru>
	<565D9859.3040405@postgrespro.ru>
	<CAKJS1f_oR+P_c+u8PtdEFyWPi4NP-vt69sQGYXTv9NQ48U5JiA@mail.gmail.com>
	<CAKJS1f_GYoJsYLJyK_92_v38x8LO5Nk+4w8=E2yqLDbTyPS7ug@mail.gmail.com>
	<CAMkU=1wZ8-mNHNMuG3BeMJkXxPyRJFNqbNnc8CaXMGxpciv8aQ@mail.gmail.com>
	<CAKJS1f9W0aB-g7H6yYgNBq7hJsOKF3UwHU7-Q5jobbaTyK9f4g@mail.gmail.com>
	<569530FC.2010900@postgrespro.ru>
	<CAMkU=1yTjAK3yCdSoVF1uf3gdvvi3qGnt691g9G0BVhwANCixw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>



12.01.2016 20:47, Jeff Janes:
> It looks like the "covering" patch, with or without the "omit_opclass"
> patch, does not support expressions as included columns:
>
> create table foobar (x text, y xml);
> create index on foobar (x) including  (md5(x));
> ERROR:  unrecognized node type: 904
> create index on foobar (x) including  ((y::text));
> ERROR:  unrecognized node type: 911
>
> I think we would probably want it to work with those (or at least to
> throw a better error message).
Thank you for the notice. I couldn't fix it quickly and added a stub in 
the latest patch.
But I'll try to fix it and add expressions support a bit later.

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (217+ messages)  latest in thread

Message-ID: <569E6F42.9040601@postgrespro.ru>
Permalink:  ../569E6F42.9040601@postgrespro.ru/
Also on:    postgresql.org/message-id/569E6F42.9040601@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: a.lubennikova@postgrespro.ru
  Subject: Re: WIP: Covering + unique indexes.
  In-Reply-To: <569E6F42.9040601@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox