pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: David Steele <david@pgmasters.net>
To: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
To: pgsql-hackers@postgresql.org
Subject: Re: [WIP] Effective storage of duplicates in B-tree index.
Date: Mon, 14 Mar 2016 09:02:06 -0400
Message-ID: <56E6B64E.6000101@pgmasters.net> (raw )
In-Reply-To: <56C5FF80.5050905@postgrespro.ru >
References: <55E4051B.7020209@postgrespro.ru >
<56AA2081.1080001@postgrespro.ru >
<CAA-aLv68Ptrnk2HpHSg9wYR0c+D2AyTB+XrS671brxqQz3dH3w@mail.gmail.com >
<56AA3E06.8040006@postgrespro.ru >
<CAA-aLv5aQezrfh2iJD97R1sQ6nqMsR2QZ_YAzNfAOkkMgO8CFQ@mail.gmail.com >
<56AB6D30.2040900@postgrespro.ru >
<20160129184733.2ca9026a@fujitsu >
<CAA-aLv7pmO41G78jfLsftsCvkXZw6dL8HZoCX9ute6nQxJv2tw@mail.gmail.com >
<56AB9866.6050207@postgrespro.ru >
<CAM3SWZQ3_PLQCH4w7uQ8q_f2t4HEseKTr2n0rQ5pxA18OeRTJw@mail.gmail.com >
<56C5FCE1.1090509@postgrespro.ru >
<56C5FF80.5050905@postgrespro.ru >
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Hi Anastasia,
On 2/18/16 12:29 PM, Anastasia Lubennikova wrote:
> 18.02.2016 20:18, Anastasia Lubennikova:
>> 04.02.2016 20:16, Peter Geoghegan:
>>> On Fri, Jan 29, 2016 at 8:50 AM, Anastasia Lubennikova
>>> <a.lubennikova@postgrespro.ru> wrote:
>>>> I fixed it in the new version (attached).
>>
>> Thank you for the review.
>> At last, there is a new patch version 3.0. After some refactoring it
>> looks much better.
>> I described all details of the compression in this document
>> https://goo.gl/50O8Q0 (the same text without pictures is attached in
>> btc_readme_1.0.txt).
>> Consider it as a rough copy of readme. It contains some notes about
>> tricky moments of implementation and questions about future work.
>> Please don't hesitate to comment it.
>>
> Sorry, previous patch was dirty. Hotfix is attached.
This looks like an extremely valuable optimization for btree indexes but
unfortunately it is not getting a lot of attention. It still applies
cleanly for anyone interested in reviewing.
It's not clear to me that you answered all of Peter's questions in [1].
I understand that you've provided a README but it may not be clear if
the answers are in there (and where).
Also, at the end of the README it says:
13. Xlog. TODO.
Does that mean the patch is not yet complete?
Thanks,
--
-David
david@pgmasters.net
[1]
http://www.postgresql.org/message-id/CAM3SWZQ3_PLQCH4w7uQ8q_f2t4HEseKTr2n0rQ5pxA18OeRTJw@mail.gmail....
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
view thread (145+ messages) latest in thread
Message-ID: <56E6B64E.6000101@pgmasters.net>
Permalink: ../56E6B64E.6000101@pgmasters.net/
Also on: postgresql.org/message-id/56E6B64E.6000101@pgmasters.net
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: david@pgmasters.net, a.lubennikova@postgrespro.ru
Subject: Re: [WIP] Effective storage of duplicates in B-tree index.
In-Reply-To: <56E6B64E.6000101@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox