From: Marko Tiikkaja <marko@joh.to>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: pgsql-hackers@postgresql.org
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Matthias Kurz <m.kurz@irregular.at>
Cc: Jim Nasby <Jim.Nasby@BlueTreble.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Subject: Re: [PATCH] Alter or rename enum value
Date: Sun, 27 Mar 2016 19:43:27 +0200
Message-ID: <56F81BBF.7010905@joh.to> (raw)
In-Reply-To: <d8jk2kn4yn0.fsf_-_@dalvik.ping.uio.no>
References: <CAO=2mx6uvgPaPDf-rHqG8=1MZnGyVDMQeh8zS4euRyyg4D35OQ@mail.gmail.com>
<56E049CC.8010201@dunslane.net>
<25605.1457539654@sss.pgh.pa.us>
<56E05635.70908@dunslane.net>
<28167.1457543612@sss.pgh.pa.us>
<CAO=2mx4rQHRvifT2yUQ1rz90A=9CVz4_Z0Sx1wTgwgQRzAimpQ@mail.gmail.com>
<CAO=2mx6rK_h4BC7y+3Nu-8fuZJXdFjd9FE_MZnzkH+vnMp0C-Q@mail.gmail.com>
<d8ja8ln7nl0.fsf@dalvik.ping.uio.no>
<d8jk2kn4yn0.fsf_-_@dalvik.ping.uio.no>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 2016-03-27 19:30, Dagfinn Ilmari Mannsåker wrote:
> ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes:
>
>> I was bored and thought "how hard could it be?", and a few hours'
>> hacking later, I have something that seems to work. It doesn't do IF
>> NOT EXISTS yet, and the error messaging could do with some improvement,
>> and there are no docs. The patch is attached, as well as at
>> https://github.com/ilmari/postgres/commit/enum-alter-value
>
> Here's v3 of the patch of the patch, which I consider ready for proper
> review.
A couple of trivial comments below.
+ <term><literal>ALTER VALUE [ IF EXISTST ] TO [ IF NOT EXISTS
]</literal></term>
typo EXISTST
+ If <literal>IF EXISTS</literal> or is <literal>IF NOT
EXISTS</literal>
+ is specified, it is not an error if the type doesn't contain
the old
double is
+ if the old value is not alreeady present or the new value is.
typo alreeady
+ * RenameEnumLabel
+ * Add a new label to the enum set. By default it goes at
copypaste-o?
+ if (!stmt->oldVal) {
not project curly brace style
.m
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: marko@joh.to, ilmari@ilmari.org, tgl@sss.pgh.pa.us, andrew@dunslane.net, m.kurz@irregular.at, Jim.Nasby@BlueTreble.com, david.g.johnston@gmail.com
Subject: Re: [PATCH] Alter or rename enum value
In-Reply-To: <56F81BBF.7010905@joh.to>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox