From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: New "-b slim" option in 2019b zic: should we turn that on?
Date: Sat, 5 Oct 2019 22:22:01 -0400
Message-ID: <56a6d366-a3a4-2e57-62a7-6be9eec0e4ea@2ndQuadrant.com> (raw)
In-Reply-To: <23096.1570314793@sss.pgh.pa.us>
References: <24998.1563403327@sss.pgh.pa.us>
<e93f047e-6c31-7a1e-b723-4418d756d9b1@2ndQuadrant.com>
<23096.1570314793@sss.pgh.pa.us>
On 10/5/19 6:33 PM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> I've just run into an issue with this (commit a1207910968). The makefile
>> now assumes that zic has this switch. But I was attempting to get around
>> an issue on msys2 by using its zic, (ZIC=/usr/bin/zic configure ...). It
>> crashes on the floor because it doesn't know about "-b slim". I think we
>> probably need a way to turn this off.
> I had contemplated injecting the -b switch via
>
> # any custom options you might want to pass to zic while installing data files
> -ZIC_OPTIONS =
> +ZIC_OPTIONS = -b slim
>
> which would allow overriding it by defining the ZIC_OPTIONS macro.
> Does that seem appropriate? I didn't do it because I worried about
> interference with existing uses of ZIC_OPTIONS ... but who knows
> whether there are any.
I don't think that's going to work very well with a buildfarm member,
where there's no convenient way to set it.
But it turns out there are bigger problems with what I'm doing, anyway,
so let's leave sleeping dogs lie for now.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew.dunstan@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: New "-b slim" option in 2019b zic: should we turn that on?
In-Reply-To: <56a6d366-a3a4-2e57-62a7-6be9eec0e4ea@2ndQuadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox