pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Joshua D. Drake <jd@commandprompt.com>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Reviewing freeze map code
Date: Fri, 6 May 2016 13:54:09 -0700
Message-ID: <572D0471.3040009@commandprompt.com> (raw)
In-Reply-To: <20160506205012.ipuhvctss2ozzs6m@alap3.anarazel.de>
References: <20160502214818.psk3lmgyihk6gr3k@alap3.anarazel.de>
	<20160505000840.epatoq6d2e556446@alap3.anarazel.de>
	<CA+TgmobF=86sa=6dF30jaiEFOhZnO+asOB5j69PynPCqtaz9xA@mail.gmail.com>
	<572D0309.4090402@commandprompt.com>
	<20160506205012.ipuhvctss2ozzs6m@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 05/06/2016 01:50 PM, Andres Freund wrote:

>>> Let's add VACUUM (FORCE) or something like that.
>
> Yes, that makes sense.
>
>
>> This is actually inverted. Vacuum by default should vacuum the entire
>> relation
>
> What? Why on earth would that be a good idea? Not to speak of hte fact
> that that's not been the case since ~8.4?

Sorry, I just meant the default behavior shouldn't change but I do agree 
that we need the ability to keep the same behavior.

>> ,however if we are going to keep the existing behavior of this
>> patch, VACUUM (FROZEN) seems to be better than (FORCE)?
>
> There already is FREEZE - meaning something different - so I doubt it.

Yeah I thought about that, it is the word "FORCE" that bothers me. When 
you use FORCE there is an assumption that no matter what, it plows 
through (think rm -f). So if we don't use FROZEN, that's cool but FORCE 
doesn't work either.

Sincerely,

JD


-- 
Command Prompt, Inc.                  http://the.postgres.company/
                         +1-503-667-4564
PostgreSQL Centered full stack support, consulting and development.
Everyone appreciates your honesty, until you are honest with them.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (256+ messages)  latest in thread

Message-ID: <572D0471.3040009@commandprompt.com>
Permalink:  ../572D0471.3040009@commandprompt.com/
Also on:    postgresql.org/message-id/572D0471.3040009@commandprompt.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: jd@commandprompt.com, andres@anarazel.de, robertmhaas@gmail.com, sawada.mshk@gmail.com
  Subject: Re: Reviewing freeze map code
  In-Reply-To: <572D0471.3040009@commandprompt.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox