pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Joshua D. Drake <jd@commandprompt.com>
To: Andres Freund <andres@anarazel.de>
Cc: Josh berkus <josh@agliodbs.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Reviewing freeze map code
Date: Fri, 6 May 2016 14:17:13 -0700
Message-ID: <572D09D9.5080407@commandprompt.com> (raw)
In-Reply-To: <20160506210806.f6pnk6ueirjqrlmu@alap3.anarazel.de>
References: <20160502214818.psk3lmgyihk6gr3k@alap3.anarazel.de>
	<20160505000840.epatoq6d2e556446@alap3.anarazel.de>
	<CA+TgmobF=86sa=6dF30jaiEFOhZnO+asOB5j69PynPCqtaz9xA@mail.gmail.com>
	<572D0309.4090402@commandprompt.com>
	<20160506205012.ipuhvctss2ozzs6m@alap3.anarazel.de>
	<572D0471.3040009@commandprompt.com>
	<20160506205824.ysst7mk3k26ztok2@alap3.anarazel.de>
	<WM!3c465a785ef366521ed338bb93585bc99a43cc6db976bb0e71111a522ee7f39a31942de6526cb0bccd5f2b7d1678818f!@asav-3.01.com>
	<572D062E.5030308@agliodbs.com>
	<572D068F.3050608@commandprompt.com>
	<20160506210806.f6pnk6ueirjqrlmu@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 05/06/2016 02:08 PM, Andres Freund wrote:

>>> VACUUM THEWHOLEDAMNTHING
>>>
>>
>> I know that would never fly but damn if that wouldn't be an awesome keyword
>> for VACUUM.
>
> It bothers me more than it probably should: Nobdy tests, reviews,
> whatever a complex patch with significant data-loss potential. But as
> soon somebody dares to mention an option name...

That is a fair complaint but let me ask you something:

How do I test?

Is there a script I can run? Are there specific things I can do to try 
and break it? What are we looking for exactly?

A lot of -hackers seem to forget that although we have 100 -hackers, we 
have 10000 "consultant/practitioners". Could I read the code and with a 
weekend of WTF and -hackers questions figure out what is going on, yes 
but a lot of people couldn't and I don't have the time.

You want me (or people like me) to test more? Give us an easy way to do 
it. Otherwise, we do what we can, which is try and interface on the 
things that will directly and immediately affect us (like keywords and 
syntax).

Sincerely,


JD


-- 
Command Prompt, Inc.                  http://the.postgres.company/
                         +1-503-667-4564
PostgreSQL Centered full stack support, consulting and development.
Everyone appreciates your honesty, until you are honest with them.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (256+ messages)  latest in thread

Message-ID: <572D09D9.5080407@commandprompt.com>
Permalink:  ../572D09D9.5080407@commandprompt.com/
Also on:    postgresql.org/message-id/572D09D9.5080407@commandprompt.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: jd@commandprompt.com, andres@anarazel.de, josh@agliodbs.com, robertmhaas@gmail.com, sawada.mshk@gmail.com
  Subject: Re: Reviewing freeze map code
  In-Reply-To: <572D09D9.5080407@commandprompt.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox