agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Antonin Houska <ah@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tomas Vondra <tomas@vondra.me>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
Date: Thu, 09 Apr 2026 08:59:00 +0200
Message-ID: <5807.1775717940@localhost> (raw)
In-Reply-To: <3074023.1775666853@sss.pgh.pa.us>
References: <202604060918.qw5ms7cbr2hz@alvherre.pgsql>
<1c197f2d-49a2-4830-8dde-55867218b62d@vondra.me>
<19118.1775645206@localhost>
<3074023.1775666853@sss.pgh.pa.us>
Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Antonin Houska <ah@cybertec.at> writes:
> > We already introduced this definition above in the function to suppress this
> > kind of warning
>
> > union
> > {
> > alignas(int32) varlena hdr;
> > char data[sizeof(void *)];
> > } chunk_header;
>
> > The problem on a 32-bit system probably is that sizeof(void *) is 4. We need
> > some other constant. Maybe (sizeof(varlena) + 1) ...
>
> This seems unnecessarily Rube Goldberg-ish already.
Indeed.
> Why not just
>
> uint64 chunk_header;
>
> It will not hurt anything if the variable has more-than-required
> alignment. And it'd be better if it were the same size everywhere.
That's certainly better. Thanks.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
view thread (416+ messages) latest in thread
Message-ID: <5807.1775717940@localhost>
Permalink: ../5807.1775717940@localhost/
Also on: postgresql.org/message-id/5807.1775717940@localhost
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ah@cybertec.at, tgl@sss.pgh.pa.us, tomas@vondra.me, alvherre@alvh.no-ip.org, vignesh21@gmail.com, srinath2133@gmail.com, amit.kapila16@gmail.com, mihailnikalayeu@gmail.com, boekewurm+postgres@gmail.com, pgsql-hackers@lists.postgresql.org, rob@xzilla.net
Subject: Re: Adding REPACK [concurrently]
In-Reply-To: <5807.1775717940@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox