pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>
To: pgsql-hackers@postgresql.org
Subject: Minor code improvement to postgresGetForeignJoinPaths
Date: Mon, 24 Oct 2016 11:26:51 +0900
Message-ID: <580D716B.1050600@lab.ntt.co.jp> (raw)
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Hi,

The last argument of create_foreignscan_path called by postgresGetForeignJoinPaths is
set to NULL, but it would be suitable to set it to NIL because the argument type is List.

Please find attached a patch.

Tatsuro Yamada
NTT Open Source Software Center

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachments:

  [text/x-patch] postgresGetForeignJoinPaths.patch (550B, ../580D716B.1050600@lab.ntt.co.jp/2-postgresGetForeignJoinPaths.patch)
  download | inline diff:
diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c
index daf0438..a5de611 100644
--- a/contrib/postgres_fdw/postgres_fdw.c
+++ b/contrib/postgres_fdw/postgres_fdw.c
@@ -4331,7 +4331,7 @@ postgresGetForeignJoinPaths(PlannerInfo *root,
 									   NIL,		/* no pathkeys */
 									   NULL,	/* no required_outer */
 									   epq_path,
-									   NULL);	/* no fdw_private */
+									   NIL);	/* no fdw_private */
 
 	/* Add generated path into joinrel by add_path(). */
 	add_path(joinrel, (Path *) joinpath);

view thread (10+ messages)  latest in thread

Message-ID: <580D716B.1050600@lab.ntt.co.jp>
Permalink:  ../580D716B.1050600@lab.ntt.co.jp/
Also on:    postgresql.org/message-id/580D716B.1050600@lab.ntt.co.jp

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: yamada.tatsuro@lab.ntt.co.jp
  Subject: Re: Minor code improvement to postgresGetForeignJoinPaths
  In-Reply-To: <580D716B.1050600@lab.ntt.co.jp>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox