pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Sergei Glukhov <s.glukhov@postgrespro.ru>
To: David Rowley <dgrowleyml@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Problem, partition pruning for prepared statement with IS NULL clause.
Date: Wed, 11 Oct 2023 13:09:36 +0400
Message-ID: <5845262d-9b6a-71f7-3485-c06e4977586f@postgrespro.ru> (raw)
In-Reply-To: <CAApHDvpf2VU4JHEBfXJsHF1Aq=+aKbtfKx3dtsZudOKLF2wu7Q@mail.gmail.com>
References: <d05b26fa-af54-27e1-f693-6c31590802fa@postgrespro.ru>
	<CAApHDvrc8BjkN8U3NUVzvat3EtC7bzLwFdUw_OFf3Sv-QCp-Vg@mail.gmail.com>
	<2f09ce72-315e-2a33-589a-8519ada8df61@postgrespro.ru>
	<CAApHDvq2gjyqkn=h95kFqRrTKUorrb9ab0bMoQnEua-v6p5Pcw@mail.gmail.com>
	<CAApHDvpf2VU4JHEBfXJsHF1Aq=+aKbtfKx3dtsZudOKLF2wu7Q@mail.gmail.com>

Hi,

Thanks for fixing this!

I verified that issues are fixed.

On 10/11/23 11:50, David Rowley wrote:

> I'm aiming to commit these as two separate fixes, so I'm going to go
> look again at the first one and wait to see if anyone wants to comment
> on this patch in the meantime.

Regarding test case for the first patch,
the line 'set plan_cache_mode = 'force_generic_plan';' is not necessary
since cache mode is set at the top of the test. On the other hand test
scenario can silently  be loosed if someone set another cache mode
somewhere upper. As you mentioned earlier it's worth maybe adding
the test for run-time partition pruning.

Regards,
Gluh






view thread (16+ messages)  latest in thread

Message-ID: <5845262d-9b6a-71f7-3485-c06e4977586f@postgrespro.ru>
Permalink:  ../5845262d-9b6a-71f7-3485-c06e4977586f@postgrespro.ru/
Also on:    postgresql.org/message-id/5845262d-9b6a-71f7-3485-c06e4977586f@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: s.glukhov@postgrespro.ru, dgrowleyml@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Problem, partition pruning for prepared statement with IS NULL clause.
  In-Reply-To: <5845262d-9b6a-71f7-3485-c06e4977586f@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox