From: Tom Lane <tgl@sss.pgh.pa.us>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: David Rowley <dgrowleyml@gmail.com>
Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size
Date: Thu, 23 Feb 2023 13:56:56 -0500
Message-ID: <587321.1677178616@sss.pgh.pa.us> (raw)
In-Reply-To: <CADkLM=c7ya93KcFxAuDp08Ngbyn5n90BHsf=E+5_2EGCubzqsQ@mail.gmail.com>
References: <20220616233130.rparivafipt6doj3@alap3.anarazel.de>
<1014296.1655422634@sss.pgh.pa.us>
<295606.1677101684@sss.pgh.pa.us>
<20230222224713.m65d55udzlq5mpbz@awork3.anarazel.de>
<CADkLM=c7ya93KcFxAuDp08Ngbyn5n90BHsf=E+5_2EGCubzqsQ@mail.gmail.com>
Corey Huinker <corey.huinker@gmail.com> writes:
> My not-ready-for-16 work on CAST( ... ON DEFAULT ... ) involved making
> FuncExpr/IoCoerceExpr/ArrayCoerceExpr have a safe_mode flag, and that
> necessitates adding a reserror boolean to ExprEvalStep for subsequent steps
> to test if the error happened.
Why do you want it in ExprEvalStep ... couldn't it be in ExprState?
I can't see why you'd need more than one at a time during evaluation.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, corey.huinker@gmail.com, andres@anarazel.de, n.gluhov@postgrespro.ru, andrew@dunslane.net, dgrowleyml@gmail.com
Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size
In-Reply-To: <587321.1677178616@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox