public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nikolay Shaplov <[email protected]>
To: Yura Sokolov <[email protected]>
To: [email protected]
To: Michael Paquier <[email protected]>
Subject: Re: [PATCH] New [relation] option engine
Date: Fri, 08 Dec 2023 15:49:31 +0300
Message-ID: <5892085.MhkbZ0Pkbq@thinkpad-pgpro> (raw)
In-Reply-To: <[email protected]>
References: <CALDaNm0OHMJSD=3RcB4Uvm8h-gEg+rrvj=A-g9_1XAbyKjG9RA@mail.gmail.com>
	<[email protected]>
	<[email protected]>

В письме от пятница, 8 декабря 2023 г. 08:59:41 MSK пользователь Michael 
Paquier написал:

> > I've rebased patch, so it could be add to commitfest again.
> 
> This is a 270kB patch with quite a few changes, and a lot of code
> 
> moved around:
> >  47 files changed, 2592 insertions(+), 2326 deletions(-)
> 
> Could it be possible to split that into more successive steps to ease
> its review?

Theoretically I can create patch with full options.c as it is in the patch 
now, and use that code only in index AM, and keep reloption.c mostly 
unchanged.

This will be total mess with two different options mechanisms working in the 
same time, but this might be much more easy to review.  When we are done with 
the first step, we can change the rest.
If this will help to finally include patch into postgres, I can do it. Will 
that help you to review?


-- 
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su


Attachments:

  [application/pgp-signature] signature.asc (488B, ../5892085.MhkbZ0Pkbq@thinkpad-pgpro/2-signature.asc)
  download

view thread (8+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] New [relation] option engine
  In-Reply-To: <5892085.MhkbZ0Pkbq@thinkpad-pgpro>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox