pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>
To: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: pgsql-hackers@postgresql.org
Subject: Re: Minor code improvement to postgresGetForeignPlan
Date: Mon, 04 Sep 2017 15:45:17 +0900
Message-ID: <59ACF67D.6090002@lab.ntt.co.jp> (raw)
In-Reply-To: <57cea27a-822b-5333-a19d-c2e1045fe9a4@lab.ntt.co.jp>
References: <58E711AF.7070305@lab.ntt.co.jp>
	<57cea27a-822b-5333-a19d-c2e1045fe9a4@lab.ntt.co.jp>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Hi Fujita-san,

> The patch looks good to me, so I'll mark this as Ready for Committer.

Thanks for reviewing my patch.


> (I'm not sure we should do the same thing to the function declaration in other places such as fdwapi.h and the documentation for consistency, but if so, I'd vote for leaving that for another patch.)

+1

Regards,
Tatsuro Yamada



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (10+ messages)  latest in thread

Message-ID: <59ACF67D.6090002@lab.ntt.co.jp>
Permalink:  ../59ACF67D.6090002@lab.ntt.co.jp/
Also on:    postgresql.org/message-id/59ACF67D.6090002@lab.ntt.co.jp

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: yamada.tatsuro@lab.ntt.co.jp, fujita.etsuro@lab.ntt.co.jp
  Subject: Re: Minor code improvement to postgresGetForeignPlan
  In-Reply-To: <59ACF67D.6090002@lab.ntt.co.jp>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox