From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL
Date: Fri, 24 May 2019 19:29:42 -0400
Message-ID: <59d22ac1-2ae6-cbf6-519c-aa2ff14fd72a@2ndQuadrant.com> (raw)
In-Reply-To: <20190524152238.khwwyl6wiflbffxw@alap3.anarazel.de>
References: <20190521194129.2kl2mldesrr65gmb@alap3.anarazel.de>
<CA+hUKGKY=p7ZeZmAiC0zK72moLyYC=HaF-Fg36s+tNEAJD6R+g@mail.gmail.com>
<7333.1558537134@sss.pgh.pa.us>
<20190522175150.c26f4jkqytahajdg@alap3.anarazel.de>
<7200.1558548407@sss.pgh.pa.us>
<20190522182027.fzytm3tciqefgz43@alap3.anarazel.de>
<7965.1558549671@sss.pgh.pa.us>
<20190522184254.vi5w4icue7vu4km5@alap3.anarazel.de>
<2b42bb13-7a7e-e295-2054-9a209749c3a7@2ndQuadrant.com>
<20190522200841.zhn64al5ysfu37kq@alap3.anarazel.de>
<20190524152238.khwwyl6wiflbffxw@alap3.anarazel.de>
On 5/24/19 11:22 AM, Andres Freund wrote:
> Hi,
>
> On 2019-05-22 13:08:41 -0700, Andres Freund wrote:
>> On 2019-05-22 16:04:34 -0400, Andrew Dunstan wrote:
>>> If I disable install, the buildfarm fails the upgrade check even when
>>> not using NO_TEMP_INSTALL.
>>>
>>>
>>> excerpts from the log:
>>> sh: /home/pgl/npgl/pg_head/bfroot/HEAD/inst/bin/psql: No such file or
>>> directory
>> That's the issue I was talking to Tom about above. Need to
>> unconditionally have
>> ....
> Andrew, after the latest set of changes, the reversed order should now
> work reliably?
>
With the latest changes I don't get the above failure:
andrew@emma:pg_head (master)$ ~/bf/client-code/run_build.pl
--skip-steps=install
master:HEAD [19:21:45] creating vpath build dir
/home/pgl/npgl/pg_head/bfroot/HEAD/pgsql.build ...
master:HEAD [19:21:45] running configure ...
master:HEAD [19:21:52] running make ...
master:HEAD [19:23:42] running make check ...
master:HEAD [19:24:37] running make contrib ...
master:HEAD [19:24:45] running make testmodules ...
master:HEAD [19:24:45] checking pg_upgrade
master:HEAD [19:26:41] checking test-decoding
master:HEAD [19:26:59] running make ecpg check ...
master:HEAD [19:27:25] OK
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew.dunstan@2ndquadrant.com, andres@anarazel.de, tgl@sss.pgh.pa.us, thomas.munro@gmail.com
Subject: Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL
In-Reply-To: <59d22ac1-2ae6-cbf6-519c-aa2ff14fd72a@2ndQuadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox