From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL
Date: Wed, 22 May 2019 10:58:54 -0400
Message-ID: <7333.1558537134@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKGKY=p7ZeZmAiC0zK72moLyYC=HaF-Fg36s+tNEAJD6R+g@mail.gmail.com>
References: <5506b8fa-7dad-8483-053c-7ca7ef04f01a@2ndQuadrant.com>
<20190521015840.cztw2qxthh7xuutk@alap3.anarazel.de>
<aaee2cc8-d722-990c-b848-413ba9913703@2ndQuadrant.com>
<20190521191918.z7kwnrlj45mk2k67@alap3.anarazel.de>
<20190521194129.2kl2mldesrr65gmb@alap3.anarazel.de>
<CA+hUKGKY=p7ZeZmAiC0zK72moLyYC=HaF-Fg36s+tNEAJD6R+g@mail.gmail.com>
Thomas Munro <thomas.munro@gmail.com> writes:
> After these commits (and Tom's commit "Un-break pg_upgrade regression
> test."), cfbot broke:
> sh: 1: /usr/local/pgsql/bin/psql: not found
I can confirm that here: check-world passes as long as I've done
"make install" beforehand ... but of course that should not be
necessary. If I blow away the install tree, pg_upgrade's
check fails at
../../../src/test/regress/pg_regress --inputdir=. --bindir='/home/postgres/testversion/bin' --port=54464 --dlpath=. --max-concurrent-tests=20 --port=54464 --schedule=./parallel_schedule
(using postmaster on /tmp/pg_upgrade_check-Nitf3h, port 54464)
============== dropping database "regression" ==============
sh: /home/postgres/testversion/bin/psql: No such file or directory
command failed: "/home/postgres/testversion/bin/psql" -X -c "DROP DATABASE IF EXISTS \"regression\"" "postgres"
pg_regress is being told the wrong --bindir, ie
the final install location not the temp install.
(More generally, should we rearrange the buildfarm test
sequence so it doesn't run "make install" till after the
tests that aren't supposed to require an installed tree?)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, andres@anarazel.de, andrew.dunstan@2ndquadrant.com
Subject: Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL
In-Reply-To: <7333.1558537134@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox