From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Oddity with parallel safety test for scan/join target in grouping_planner
Date: Mon, 11 Mar 2019 14:29:50 +0900
Message-ID: <5C85F24E.4050404@lab.ntt.co.jp> (raw)
In-Reply-To: <1962.1552281261@sss.pgh.pa.us>
References: <5C75303E.8020303@lab.ntt.co.jp>
<CA+TgmobmV=Zw2OEJKUorJe=e+_fCzsvYErR6tXxTjCzK45x9RQ@mail.gmail.com>
<5C7908B9.5070407@lab.ntt.co.jp>
<24818.1552077419@sss.pgh.pa.us>
<5C85DC65.2050409@lab.ntt.co.jp>
<32401.1552277190@sss.pgh.pa.us>
<5C85ED63.8000805@lab.ntt.co.jp>
<1962.1552281261@sss.pgh.pa.us>
(2019/03/11 14:14), Tom Lane wrote:
> Etsuro Fujita<fujita.etsuro@lab.ntt.co.jp> writes:
>> (2019/03/11 13:06), Tom Lane wrote:
>>> Is that the only possible outcome? Per Robert's summary quoted above,
>>> it seems like it might be possible for the code to decide that the final
>>> scan/join target to be parallel safe when it is not, leading to outright
>>> wrong answers or query failures.
>
>> Maybe I'm missing something, but I think that if the final scan/join
>> target is not parallel-safe, then the grouping target would not be
>> parallel-safe either, by the construction of the two targets, so I don't
>> think that we have such a correctness issue.
>
> Seems to me it's the other way around: the final target would include
> all functions invoked in the grouping target plus maybe some more.
> So a non-parallel-safe grouping target implies a non-parallel-safe
> final target, but not vice versa.
I mean the final *scan/join* target, not the final target.
Best regards,
Etsuro Fujita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: fujita.etsuro@lab.ntt.co.jp, tgl@sss.pgh.pa.us, robertmhaas@gmail.com
Subject: Re: Oddity with parallel safety test for scan/join target in grouping_planner
In-Reply-To: <5C85F24E.4050404@lab.ntt.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox