pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Oddity with parallel safety test for scan/join target in grouping_planner
Date: Tue, 12 Mar 2019 16:44:20 +0900
Message-ID: <5C876354.1000905@lab.ntt.co.jp> (raw)
In-Reply-To: <22068.1552315572@sss.pgh.pa.us>
References: <5C75303E.8020303@lab.ntt.co.jp>
	<CA+TgmobmV=Zw2OEJKUorJe=e+_fCzsvYErR6tXxTjCzK45x9RQ@mail.gmail.com>
	<5C7908B9.5070407@lab.ntt.co.jp>
	<24818.1552077419@sss.pgh.pa.us>
	<5C85DC65.2050409@lab.ntt.co.jp>
	<32401.1552277190@sss.pgh.pa.us>
	<5C85ED63.8000805@lab.ntt.co.jp>
	<1962.1552281261@sss.pgh.pa.us>
	<5C85F24E.4050404@lab.ntt.co.jp>
	<22068.1552315572@sss.pgh.pa.us>

(2019/03/11 23:46), Tom Lane wrote:
> So this is
> just a plan-quality problem not a wrong-answer problem.
>
> However, I'd still argue for back-patching into v11, on the grounds
> that this is a regression from v10.  The example you just gave does
> produce the desired plan in v10, and I think it's more likely that
> people would complain about a regression from v10 than that they'd
> be unhappy because we changed it between 11.2 and 11.3.

Agreed.  I committed the patch to v11 and HEAD.  Thanks for reviewing!

Best regards,
Etsuro Fujita





view thread (12+ messages)

Message-ID: <5C876354.1000905@lab.ntt.co.jp>
Permalink:  ../5C876354.1000905@lab.ntt.co.jp/
Also on:    postgresql.org/message-id/5C876354.1000905@lab.ntt.co.jp

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: fujita.etsuro@lab.ntt.co.jp, tgl@sss.pgh.pa.us, robertmhaas@gmail.com
  Subject: Re: Oddity with parallel safety test for scan/join target in grouping_planner
  In-Reply-To: <5C876354.1000905@lab.ntt.co.jp>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox