public inbox for [email protected]help / color / mirror / Atom feed
[PATCH 08/10] Default to zstd.. 3+ messages / 3 participants [nested] [flat]
* [PATCH 08/10] Default to zstd.. @ 2021-03-12 21:35 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Justin Pryzby @ 2021-03-12 21:35 UTC (permalink / raw) for CI, not for merge --- configure | 6 ++++-- configure.ac | 2 +- src/backend/access/transam/xlog.c | 2 +- src/backend/utils/misc/guc.c | 2 +- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 81e23418b2..253f028fc4 100755 --- a/configure +++ b/configure @@ -1582,7 +1582,7 @@ Optional Packages: use system time zone data in DIR --without-zlib do not use Zlib --without-lz4 build without LZ4 support - --with-zstd build with Zstd compression library + --without-zstd build without Zstd compression library --with-gnu-ld assume the C compiler uses GNU ld [default=no] --with-ssl=LIB use LIB for SSL/TLS support (openssl) --with-openssl obsolete spelling of --with-ssl=openssl @@ -8740,7 +8740,9 @@ $as_echo "#define USE_ZSTD 1" >>confdefs.h esac else - with_zstd=no + with_zstd=yes + +$as_echo "#define USE_ZSTD 1" >>confdefs.h fi diff --git a/configure.ac b/configure.ac index d6f6349067..8d72710fa7 100644 --- a/configure.ac +++ b/configure.ac @@ -1005,7 +1005,7 @@ fi # ZSTD # AC_MSG_CHECKING([whether to build with zstd support]) -PGAC_ARG_BOOL(with, zstd, no, [build with Zstd compression library], +PGAC_ARG_BOOL(with, zstd, yes, [build without Zstd compression library], [AC_DEFINE([USE_ZSTD], 1, [Define to 1 to build with zstd support. (--with-zstd)])]) AC_MSG_RESULT([$with_zstd]) AC_SUBST(with_zstd) diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 307eee6626..92023de9f5 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -99,7 +99,7 @@ bool EnableHotStandby = false; bool fullPageWrites = true; bool wal_log_hints = false; bool wal_compression = false; -int wal_compression_method = WAL_COMPRESSION_LZ4; +int wal_compression_method = WAL_COMPRESSION_ZSTD; char *wal_consistency_checking_string = NULL; bool *wal_consistency_checking = NULL; bool wal_init_zero = true; diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 52f9cd0242..8031e027aa 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -4728,7 +4728,7 @@ static struct config_enum ConfigureNamesEnum[] = NULL }, &wal_compression_method, - WAL_COMPRESSION_LZ4, wal_compression_options, + WAL_COMPRESSION_ZSTD, wal_compression_options, NULL, NULL, NULL }, -- 2.17.0 --XsQoSWH+UP9D9v3l Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0009-Add-zstd-compression-levels.patch" ^ permalink raw reply [nested|flat] 3+ messages in thread
* index_delete_sort: Unnecessary variable "low" is used in heapam.c @ 2024-09-24 08:32 btnakamurakoukil <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: btnakamurakoukil @ 2024-09-24 08:32 UTC (permalink / raw) To: [email protected] Hi hackers, I noticed unnecessary variable "low" in index_delete_sort() (/postgres/src/backend/access/heap/heapam.c), patch attached. What do you think? Regards, Koki Nakamura <[email protected]> Attachments: [text/x-diff] 0001-Delete-low.patch (1023B, ../../[email protected]/2-0001-Delete-low.patch) download | inline diff: From c0bf7f8468cb0e4f74c41e434adf70bdbfb3ad6d Mon Sep 17 00:00:00 2001 From: KokiNaka <[email protected]> Date: Tue, 24 Sep 2024 10:46:09 +0900 Subject: [PATCH] Delete low --- src/backend/access/heap/heapam.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c index f167107257..64953541cd 100644 --- a/src/backend/access/heap/heapam.c +++ b/src/backend/access/heap/heapam.c @@ -7940,7 +7940,6 @@ index_delete_sort(TM_IndexDeleteOp *delstate) { TM_IndexDelete *deltids = delstate->deltids; int ndeltids = delstate->ndeltids; - int low = 0; /* * Shellsort gap sequence (taken from Sedgewick-Incerpi paper). @@ -7956,7 +7955,7 @@ index_delete_sort(TM_IndexDeleteOp *delstate) for (int g = 0; g < lengthof(gaps); g++) { - for (int hi = gaps[g], i = low + hi; i < ndeltids; i++) + for (int hi = gaps[g], i = hi; i < ndeltids; i++) { TM_IndexDelete d = deltids[i]; int j = i; -- 2.40.1 ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: index_delete_sort: Unnecessary variable "low" is used in heapam.c @ 2024-09-24 12:31 Daniel Gustafsson <[email protected]> parent: btnakamurakoukil <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Daniel Gustafsson @ 2024-09-24 12:31 UTC (permalink / raw) To: btnakamurakoukil <[email protected]>; +Cc: PostgreSQL Developers <[email protected]>; Peter Geoghegan <[email protected]> > On 24 Sep 2024, at 10:32, btnakamurakoukil <[email protected]> wrote: > I noticed unnecessary variable "low" in index_delete_sort() (/postgres/src/backend/access/heap/heapam.c), patch attached. What do you think? That variable does indeed seem to not be used, and hasn't been used since it was committed in d168b666823. The question is if it's a left-over from development which can be removed, or if it should be set and we're missing an optimization. Having not read the referenced paper I can't tell so adding Peter Geoghegan who wrote this for clarification. -- Daniel Gustafsson ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-09-24 12:31 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-03-12 21:35 [PATCH 08/10] Default to zstd.. Justin Pryzby <[email protected]> 2024-09-24 08:32 index_delete_sort: Unnecessary variable "low" is used in heapam.c btnakamurakoukil <[email protected]> 2024-09-24 12:31 ` Re: index_delete_sort: Unnecessary variable "low" is used in heapam.c Daniel Gustafsson <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox