From: Brar Piening <brar@gmx.de>
To: Karl O. Pinc <kop@karlpinc.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences
Date: Sun, 15 Jan 2023 07:11:30 +0100
Message-ID: <5b5f6cdd-e003-bbc2-7bed-b7847e9660b3@gmx.de> (raw)
In-Reply-To: <20230102180015.372995a9@slate.karlpinc.com>
References: <20230102180015.372995a9@slate.karlpinc.com>
On 03.01.2023 at 01:00, Karl O. Pinc wrote:
> Attached is a patch: contrib_v1.patch
>
> It modifies Appendix F, the contrib directory.
Review:
The patch applies cleanly (1334b79a35 - 2023-01-14 18:05:09 +0900).
It adds a brief explanatory part to the headers of all contrib modules
which I consider as very useful, especially when looking at the TOC in
contrib.html where currently newcomers would need to click through all
the links to even get an idea what the various modules do.
The explanatory parts added make sense to me, althogh I'm not an expert
in all the different contrib modules.
Appendix F. now reads as "Additional Supplied Modules and Extensions"
instead of "Appendix F. Additional Supplied Modules" which IMHO proprely
reflects what it is about. The original title probably comes from the
pre-extension-era.
There is also some minor rewording of sentences in contrib.sgml that in
general looks like an improvment to me.
In conclusion I cannot see why this patch should not be applied in it's
current form so I deem it ready for commiter.
Regards,
Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: brar@gmx.de, kop@karlpinc.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences
In-Reply-To: <5b5f6cdd-e003-bbc2-7bed-b7847e9660b3@gmx.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox