From: Andrew Dunstan <andrew@dunslane.net>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Noah Misch <noah@leadboat.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: "debug_invalidate_system_caches_always" is too long
Date: Tue, 6 Jul 2021 05:50:14 -0400
Message-ID: <5f1332ab-d2ee-e31d-ecf7-62cc7d150b09@dunslane.net> (raw)
In-Reply-To: <CALj2ACVT4ga=RDYsBzLg3DXg2ENat2V-eh4yw8oH65Z1CNkJ6g@mail.gmail.com>
References: <1374320.1625430433@sss.pgh.pa.us>
<20210704211234.GD2421985@rfd.leadboat.com>
<1492832.1625512421@sss.pgh.pa.us>
<CALj2ACVT4ga=RDYsBzLg3DXg2ENat2V-eh4yw8oH65Z1CNkJ6g@mail.gmail.com>
On 7/5/21 11:46 PM, Bharath Rupireddy wrote:
> On Tue, Jul 6, 2021 at 12:43 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Noah Misch <noah@leadboat.com> writes:
>>> On Sun, Jul 04, 2021 at 04:27:13PM -0400, Tom Lane wrote:
>>>> However, I think we should also give serious consideration to
>>>> "debug_clobber_cache" or "debug_clobber_cache_always" for continuity
>>>> with past practice (though it still feels like "always" is a good
>>>> word to lose now). "debug_clobber_caches" is another reasonable
>>>> variant.
>>> https://en.wikipedia.org/wiki/Clobbering refers to cases where storage had no
>>> changes to its accessibility but now contains different data. That doesn't
>>> match InvalidateSystemCaches() especially well, so I think dropping that word
>>> has been a good step. Some other shorter terms could be debug_flush_caches,
>>> debug_rebuild_caches, or debug_expire_caches. (debug_caches is tempting, but
>>> that may ensnare folks looking for extra logging rather than a big slowdown.)
>> I like "debug_flush_caches" --- it's short and accurate.
> Do we always flush the cache entries into the disk? Sometimes we just
> invalidate the cache entries in the registered invalidation callbacks,
> right? Since we already use the term "clobber" in the user visible
> config option --clobber-cache, isn't it consistent to use
> debug_clobber_caches?
>
I think 'flush' here means simply 'discard'. Maybe that would be a
better word to use.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew@dunslane.net, bharath.rupireddyforpostgres@gmail.com, tgl@sss.pgh.pa.us, noah@leadboat.com, pgsql-hackers@lists.postgresql.org
Subject: Re: "debug_invalidate_system_caches_always" is too long
In-Reply-To: <5f1332ab-d2ee-e31d-ecf7-62cc7d150b09@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox