From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Gregory Stark <stark@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org, "Greg Stark" <greg.stark@enterprisedb.com>
Cc: ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Subject: Re: [SPAM] Re: posix_fadvise v22
Date: Sat, 10 Jan 2009 14:07:06 -0500
Message-ID: <603c8f070901101107m3321d2acu439cea602d6c7a1c@mail.gmail.com> (raw)
In-Reply-To: <24021.1231613465@sss.pgh.pa.us>
References: <FDDBA24E-FF4D-4654-BA75-692B3BA71B97@enterprisedb.com>
<603c8f070901012011hca2c36flf527a5cd01695205@mail.gmail.com>
<262184F8-1206-4E2C-B50F-9FF84E63C1B6@enterprisedb.com>
<200901032342.19435.peter_e@gmx.net>
<87iqowt3ba.fsf@oxford.xeocode.com>
<4961C80C.6030307@gmx.net>
<24021.1231613465@sss.pgh.pa.us>
> I think at a minimum there should be a manual configuration switch
> (ie something in pg_config_manual.h) to allow the builder to disable
> use of posix_fadvise, even if configure thinks it's there. Depending
> on buildfarm results we may have to do more than that.
This seems pretty pointless, since there is already a GUC to control
the behavior, and the default is off. The only value here would be if
you could demonstrate that even with effective_io_concurrency set to 1
there is a significant performance dropoff. But that would probably
be an argument for rejecting the patch outright, not adding a
compile-time switch.
...Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: robertmhaas@gmail.com, tgl@sss.pgh.pa.us, peter_e@gmx.net, stark@enterprisedb.com, greg.stark@enterprisedb.com, itagaki.takahiro@oss.ntt.co.jp
Subject: Re: [SPAM] Re: posix_fadvise v22
In-Reply-To: <603c8f070901101107m3321d2acu439cea602d6c7a1c@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox