From: Robert Haas <robertmhaas@gmail.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: KaiGai Kohei <kaigai@ak.jp.nec.com>
Cc: KaiGai Kohei <kaigai@kaigai.gr.jp>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Reworks for Access Control facilities (r2311)
Date: Tue, 29 Sep 2009 09:41:58 -0400
Message-ID: <603c8f070909290641r62a5205ama3fbc98f98133fe0@mail.gmail.com> (raw)
In-Reply-To: <20090929105431.GO17756@tamriel.snowman.net>
References: <20090929105431.GO17756@tamriel.snowman.net>
On Tue, Sep 29, 2009 at 6:54 AM, Stephen Frost <sfrost@snowman.net> wrote:
> * KaiGai Kohei (kaigai@ak.jp.nec.com) wrote:
>> Could you post any review comments, even if it is not comprehensive yet?
>
> In general, you don't need to preface your comments with 'MEMO:'. I
> would encourage removing that. You might use 'FIXME:' instead, if it is
> something which needs to be corrected in the future. Additionally,
> please think about PG as a whole project. Talking about 'native
> privilege mechanism' implies there are 'native' and 'foreign' ones. I
> would recommend using the term 'default' instead.
Or maybe 'standard'?
...Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: robertmhaas@gmail.com, sfrost@snowman.net, kaigai@ak.jp.nec.com, kaigai@kaigai.gr.jp
Subject: Re: [PATCH] Reworks for Access Control facilities (r2311)
In-Reply-To: <603c8f070909290641r62a5205ama3fbc98f98133fe0@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox