From: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org, Paul Ramsey <pramsey@cleverelephant.ca>
Subject: Re: [PATCH] random_normal function
Date: Thu, 19 Jan 2023 11:48:20 +0500
Message-ID: <612be20c-da68-7a6c-9f2b-297edc47d459@postgrespro.ru> (raw)
In-Reply-To: <4000009.1674108095@sss.pgh.pa.us>
References: <CACowWR0DqHAvOKUCNxTrASFkWsDLqKMd6WiXvVvaWg4pV1BMnQ@mail.gmail.com>
<20221208224623.GQ27893@telsasoft.com>
<F103485B-F7B3-40CF-A149-17BA70AF2B61@cleverelephant.ca>
<20221231035804.GJ1153@telsasoft.com>
<Y7OR5nh8qetbwgXX@paquier.xyz>
<1682143.1672713508@sss.pgh.pa.us>
<1776287.1672764097@sss.pgh.pa.us>
<3983784.1673223640@sss.pgh.pa.us>
<3996998.1673230641@sss.pgh.pa.us>
<4173840.1673290336@sss.pgh.pa.us>
<72017e35-9b16-9223-d785-3e5a452f186a@postgrespro.ru>
<4000009.1674108095@sss.pgh.pa.us>
On 1/19/23 11:01, Tom Lane wrote:
> Andrey Lepikhov <a.lepikhov@postgrespro.ru> writes:
>> On 1/9/23 23:52, Tom Lane wrote:
>>> BTW, if this does bring the probability of failure down to the
>>> one-in-a-billion range, I think we could also nuke the whole
>>> "ignore:" business, simplifying pg_regress and allowing the
>>> random test to be run in parallel with others.
>
>> We have used the pg_sleep() function to interrupt a query at certain
>> execution phase. But on some platforms, especially in containers, the
>> query can vary execution time in so widely that the pg_sleep() timeout,
>> required to get rid of dependency on a query execution time, has become
>> unacceptable. So, the "ignore" option was the best choice.
>
> But does such a test have any actual value? If your test infrastructure
> ignores the result, what makes you think you'd notice if the test did
> indeed detect a problem?
Yes, it is good to catch SEGFAULTs and assertions which may be frequent
because of a logic complexity in the case of timeouts.
>
> I think "ignore:" was a kluge we put in twenty-plus years ago when our
> testing standards were a lot lower, and it's way past time we got
> rid of it.
Ok, I will try to invent alternative way for deep (and stable) testing
of timeouts. Thank you for the answer.
--
Regards
Andrey Lepikhov
Postgres Professional
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: a.lepikhov@postgrespro.ru, tgl@sss.pgh.pa.us, dean.a.rasheed@gmail.com, coelho@cri.ensmp.fr, michael@paquier.xyz, pryzby@telsasoft.com, pramsey@cleverelephant.ca
Subject: Re: [PATCH] random_normal function
In-Reply-To: <612be20c-da68-7a6c-9f2b-297edc47d459@postgrespro.ru>
References: <CACowWR0DqHAvOKUCNxTrASFkWsDLqKMd6WiXvVvaWg4pV1BMnQ@mail.gmail.com> <20221208224623.GQ27893@telsasoft.com> <F103485B-F7B3-40CF-A149-17BA70AF2B61@cleverelephant.ca> <20221231035804.GJ1153@telsasoft.com> <Y7OR5nh8qetbwgXX@paquier.xyz> <1682143.1672713508@sss.pgh.pa.us> <1776287.1672764097@sss.pgh.pa.us> <3983784.1673223640@sss.pgh.pa.us> <3996998.1673230641@sss.pgh.pa.us> <4173840.1673290336@sss.pgh.pa.us> <72017e35-9b16-9223-d785-3e5a452f186a@postgrespro.ru> <4000009.1674108095@sss.pgh.pa.us> <612be20c-da68-7a6c-9f2b-297edc47d459@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox