From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Unified logging system for command-line programs
Date: Thu, 03 Jan 2019 16:01:14 -0500
Message-ID: <6174.1546549274@sss.pgh.pa.us> (raw)
In-Reply-To: <a7c07b9c-8aa4-f9bb-e9eb-30111b732645@2ndquadrant.com>
References: <6a609b43-4f57-7348-6480-bd022f924310@2ndquadrant.com>
<21141.1546199123@sss.pgh.pa.us>
<20181231155557.7mokxwg7fnvoxd4a@alap3.anarazel.de>
<841dd9fb-3550-dce0-e9ff-8f64cac9f15d@2ndquadrant.com>
<20190103180315.o4gh3id5quh5aebc@alap3.anarazel.de>
<a7c07b9c-8aa4-f9bb-e9eb-30111b732645@2ndquadrant.com>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 03/01/2019 19:03, Andres Freund wrote:
>>> Relatedly, rewriting all the frontend programs to exception style would
>>> end up being a 10x project to rewrite everything for no particular
>>> benefit. Going from 8 or so APIs to 2 is already an improvement, I
>>> think. If someone wants to try going further, it can be considered, but
>>> it would be an entirely different project.
>> Why would it be 10x the effort,
> Because you would have to rewrite all the programs to handle elog(ERROR)
> jumping somewhere else.
FWIW, this argument has nothing to do with what I was actually
proposing. I envisioned that we'd have a wrapper in which
non-error ereports() map directly onto what you're calling
pg_log_debug, pg_log_warning, etc, while ereport(ERROR) has the
effect of writing a message and then calling exit(1). We would
use ereport(ERROR) in exactly the places where we're now writing
a message and calling exit(1). No change at all in program
flow control, but an opportunity to consolidate code in places
that are currently doing this sort of thing:
#ifndef FRONTEND
ereport(ERROR,
(errcode_for_file_access(),
errmsg("could not open file \"%s\" for reading: %m",
ControlFilePath)));
#else
{
fprintf(stderr, _("%s: could not open file \"%s\" for reading: %s\n"),
progname, ControlFilePath, strerror(errno));
exit(EXIT_FAILURE);
}
#endif
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, andres@anarazel.de
Subject: Re: Unified logging system for command-line programs
In-Reply-To: <6174.1546549274@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox