pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Euler Taveira <euler@eulerto.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: osumi.takamichi@fujitsu.com <osumi.takamichi@fujitsu.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: tanghy.fnst@fujitsu.com <tanghy.fnst@fujitsu.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Greg Nancarrow <gregn4422@gmail.com>
Cc: houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com>
Cc: Alexey Lesovsky <lesovsky@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Skipping logical replication transactions on subscriber side
Date: Mon, 21 Mar 2022 09:21:18 -0300
Message-ID: <6320e1d2-b4fd-4e3e-9cae-3373fd6263fe@www.fastmail.com> (raw )
In-Reply-To: <CAA4eK1JbLRj6pSUENfDFsqj0+adNob_=RPXpnUnWFBskVi5JhA@mail.gmail.com >
References: <CAA4eK1LoUULzh-WreQe3TcL5s5oUG3c1bibC8rSThqknvvKvPQ@mail.gmail.com >
<78a7ef21-bb27-f78a-521e-94ddb4d5c669@enterprisedb.com >
<CAKFQuwY=7v9xyb4A4m6dBnTJyRXvOFnpqnTgauL1US=WO_Ukdg@mail.gmail.com >
<CAD21AoBf5ZY9Gv07GR10c-f8NmdeX+zvYEbp7JL3kMh9OB6Rig@mail.gmail.com >
<CAKFQuwa4GUDTqkjdmhrt=4XREX=GTjFhfoRdG6X0uocwtpGvxA@mail.gmail.com >
<CAD21AoBoMaCMTga7LYN7JEvhBs_gBqa8RLgxM3GBMxRn6f+8qA@mail.gmail.com >
<CAA4eK1LANoQHgP4Rfe04nf1RWNhwckJ-+Osp+hmm7JuYZ+Wufw@mail.gmail.com >
<CAD21AoCU2PLm+SxdOdUMpjgHioMB6baOoxqNi_XHD6QQJF+RKg@mail.gmail.com >
<CAD21AoDHCAD9anS6ZzNyG1-B7F_BvzyiNfZ=O-tMEdwmKhfW8A@mail.gmail.com >
<CAA4eK1J6VNwofqvs+kLCdf_wWztFLzet0d0N64xOoyx9DgivAw@mail.gmail.com >
<CAD21AoDL5Vbi438UOJs=Z4O_5HevVa7aeJzCM2jHcXDb48PZhw@mail.gmail.com >
<cfcc839b-0851-4112-a7c5-1543d129e811@enterprisedb.com >
<CAD21AoCuuyNNNspQ9pBeieo_tzsLp8=ruag9NHgOv58PkAfQcQ@mail.gmail.com >
<CAA4eK1+DDLOHNJWTWy-fsO8hK4E1dFvDhrKrfgW5kRUjo=Uenw@mail.gmail.com >
<56e64628-940b-dca9-1388-872a914f8ea0@enterprisedb.com >
<CAD21AoCTHQDvq7gWdP4BFpjCYswcFRnHyzAUJn16zSPD4bO4bg@mail.gmail.com >
<CAA4eK1LZ4sH2MRB-mDexvRB4v7Qzda7tE=-tn_o1k361aSkoag@mail.gmail.com >
<CAD21AoCdczrC_xOk2Anx=PeszgxxiWO5yaPztaEhiv9f6AzZig@mail.gmail.com >
<TYCPR01MB8373CA152C0FC163523F746AED0F9@TYCPR01MB8373.jpnprd01.prod.outlook.com >
<CAD21AoBTEOBVuX8NYVxtvddVGvgi7gsDN_9xnMXJz_puux8YRw@mail.gmail.com >
<CAA4eK1LK6tOuqON3HtVGU7THyX82awJA16CO_gKyrQ80haQ6ng@mail.gmail.com >
<CAD21AoCwYVdiDMGkmm6Rg5=VTDyB=zWFYHkJ2fjT6DaD+hOe7w@mail.gmail.com >
<CAA4eK1KwKVV-+ooiHH19=4YyfHyWfXS617+T-ePL=N4pfep_OA@mail.gmail.com >
<CAA4eK1JO-B67Qf_ftj_YOCvwbsW=3mk+tXivXHfbxZZBDA-cjg@mail.gmail.com >
<CAD21AoDL8HGh7AExZsXvkJzrBN9zgk78sJoQiurnvf88xtM5XA@mail.gmail.com >
<CAA4eK1KCMdKUMGCMi_qk5-SmSKSe1jGzRyYMh0pfmEdx_B47YA@mail.gmail.com >
<c092b93b-5017-4b31-b8f0-53b0ba7995be@www.fastmail.com >
<CAA4eK1JbLRj6pSUENfDFsqj0+adNob_=RPXpnUnWFBskVi5JhA@mail.gmail.com >
On Mon, Mar 21, 2022, at 12:25 AM, Amit Kapila wrote:
> I have fixed all the above comments as per your suggestion in the
> attached. Do let me know if something is missed?
Looks good to me.
> > src/test/subscription/t/029_disable_on_error.pl | 94 ----------
> > src/test/subscription/t/029_on_error.pl | 183 +++++++++++++++++++
> >
> > It seems you are removing a test for 705e20f8550c0e8e47c0b6b20b5f5ffd6ffd9e33.
> > I should also name 029_on_error.pl to something else such as 030_skip_lsn.pl or
> > a generic name 030_skip_option.pl.
> >
>
> As explained in my previous email, I don't think any change is
> required for this comment but do let me know if you still think so?
Oh, sorry about the noise. I saw mixed tests between the 2 new features and I
was confused if it was intentional or not.
--
Euler Taveira
EDB https://www.enterprisedb.com/
view thread (590+ messages) latest in thread
Message-ID: <6320e1d2-b4fd-4e3e-9cae-3373fd6263fe@www.fastmail.com>
Permalink: ../6320e1d2-b4fd-4e3e-9cae-3373fd6263fe@www.fastmail.com/
Also on: postgresql.org/message-id/6320e1d2-b4fd-4e3e-9cae-3373fd6263fe@www.fastmail.com
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: euler@eulerto.com, amit.kapila16@gmail.com, sawada.mshk@gmail.com, osumi.takamichi@fujitsu.com, peter.eisentraut@enterprisedb.com, david.g.johnston@gmail.com, tanghy.fnst@fujitsu.com, vignesh21@gmail.com, gregn4422@gmail.com, houzj.fnst@fujitsu.com, lesovsky@gmail.com
Subject: Re: Skipping logical replication transactions on subscriber side
In-Reply-To: <6320e1d2-b4fd-4e3e-9cae-3373fd6263fe@www.fastmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox